Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce confusion around update notification buttons #998

Closed
MattJeanes opened this issue Nov 23, 2023 · 2 comments
Closed

Reduce confusion around update notification buttons #998

MattJeanes opened this issue Nov 23, 2023 · 2 comments

Comments

@MattJeanes
Copy link
Owner

There is some confusion about what "Don't ask again" means in the in-game release notes popup

We should clarify it's meaning that it will hide all future updates

@MattJeanes
Copy link
Owner Author

Turns out this was actually just broken and it was showing every game launch even if you saw the popup for this update already, which was leading to the confusion.

Caused by the removal of the migrations for two reasons:

  • There were no clientside migrations on 2023.8.0 anymore so the file.Write version code did not run which it should always
  • The file moves caused the folder to be created which doesn't happen with file.Write for some reason

We now:

  • Always write the version on startup regardless of if there are any migrations
  • Explicitly create the "tardis" folder on startup

I have also changed the button text to "Never show updates" to further clarify the button behaviour

This has been released as an emergency hotfix

@github-project-automation github-project-automation bot moved this from New to Closed in GMod Doctor Who Nov 23, 2023
@MattJeanes
Copy link
Owner Author

Fixed in 1c7fac2 + 3432980

@parar020100 parar020100 moved this from Closed to Merged in GMod Doctor Who Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

No branches or pull requests

1 participant