Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit messages should be written in the imperitive #6

Closed
MatthewL246 opened this issue Nov 24, 2020 · 2 comments
Closed

Commit messages should be written in the imperitive #6

MatthewL246 opened this issue Nov 24, 2020 · 2 comments
Labels
wontfix This will not be worked on

Comments

@MatthewL246
Copy link
Owner

Write your commit message in the imperative: "Fix bug" and not "Fixed bug" or "Fixes bug." This convention matches up with commit messages generated by commands like git merge and git revert.

For example, "Added a new file" should be "Add a new file." "Edit the new file" is already good. Actually, now that I look at the full history, it's pretty good. This is just a reminder for me.

@MatthewL246 MatthewL246 self-assigned this Nov 24, 2020
@MatthewL246
Copy link
Owner Author

MatthewL246 commented Nov 24, 2020

I will not fix this.

@MatthewL246 MatthewL246 added the wontfix This will not be worked on label Nov 24, 2020
@MatthewL246 MatthewL246 pinned this issue Nov 24, 2020
@MatthewL246 MatthewL246 unpinned this issue Nov 24, 2020
@MatthewL246
Copy link
Owner Author

A properly formed Git commit subject line should always be able to complete this sentence: This commit will . . .

For example, "This commit will add a new file and edit that new file." "This commit will added a new file" is wrong.

@MatthewL246 MatthewL246 reopened this Feb 24, 2021
@MatthewL246 MatthewL246 removed their assignment Mar 25, 2021
@MatthewL246 MatthewL246 closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant