Fix #323 - A newly added explosion doesn't gets saved into firework's…

… namedtag
MemoriesOfTime · Oct 6, 2024 · 3b0b2f9 · 3b0b2f9
1 parent 438fa1c
commit 3b0b2f9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/java/cn/nukkit/item/ItemFirework.java b/src/main/java/cn/nukkit/item/ItemFirework.java
@@ -105,15 +105,16 @@ public void addExplosion(FireworkExplosion explosion) {
             fds[i] = (byte) fades.get(i).getDyeData();
         }
 
-        ListTag<CompoundTag> explosions = this.getNamedTag().getCompound("Fireworks").getList("Explosions", CompoundTag.class);
+        CompoundTag namedTag = this.getNamedTag();
+        ListTag<CompoundTag> explosions = namedTag.getCompound("Fireworks").getList("Explosions", CompoundTag.class);
         CompoundTag tag = new CompoundTag()
                 .putByteArray("FireworkColor", clrs)
                 .putByteArray("FireworkFade", fds)
                 .putBoolean("FireworkFlicker", explosion.flicker)
                 .putBoolean("FireworkTrail", explosion.trail)
                 .putByte("FireworkType", explosion.type.ordinal());
-
         explosions.add(tag);
+        this.setNamedTag(namedTag);
     }
 
     public void clearExplosions() {