Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Re-use of doctrine collections #12

Open
scaytrase opened this issue Dec 26, 2016 · 2 comments
Open

[RFC] Re-use of doctrine collections #12

scaytrase opened this issue Dec 26, 2016 · 2 comments

Comments

@scaytrase
Copy link

Your collection implementation looks similar to Doctrines ArrayCollectionwithObjectRepository` ontop of it. What do you think about re-using some code from there?

https://github.com/doctrine/collections/blob/master/lib/Doctrine/Common/Collections/ArrayCollection.php

https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Persistence/ObjectRepository.php

https://github.com/doctrine/collections/blob/master/lib/Doctrine/Common/Collections/Selectable.php

This could lead to some interoperability with other libraries.

@dusterio
Copy link
Member

You are right - nowadays most collection implementations are very similar (I've personally tried Laravel's, CakePHP's and Doctrine). I'll check - maybe I really should just import (probably extend) collection class from Doctrine or somewhere else

@greabock
Copy link

Laravel's collections can be used standalone with https://github.com/tightenco/collect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants