Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unreleased" link broken #39

Closed
rekmarks opened this issue May 2, 2021 · 2 comments
Closed

"Unreleased" link broken #39

rekmarks opened this issue May 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@rekmarks
Copy link
Member

rekmarks commented May 2, 2021

The Unreleased URL is at least sometimes generated in a broken state, e.g.:

[unreleased]: https://github.com/MetaMask/post-message-stream.git/v3.0.0...HEAD

The above 404s. The correct URL would be:

[unreleased]: https://github.com/MetaMask/post-message-stream/compare/v3.0.0...HEAD

It's also unclear to me whether it should force-lowercase unreleased? It overwrote a link with Unreleased in my testing.

@rekmarks rekmarks added the bug Something isn't working label May 2, 2021
@rekmarks rekmarks changed the title Unreleased link broken "Unreleased" link broken May 3, 2021
@Gudahtt
Copy link
Member

Gudahtt commented May 4, 2021

I can't reproduce this. It seems to always be upper-case in my testing, and I haven't seen that mangled URL used yet.

@Gudahtt
Copy link
Member

Gudahtt commented May 4, 2021

After speaking with @rekmarks about this, our best guess is that this error was encountered with an older version of this repo. Closing for now since we can't repro this.

@Gudahtt Gudahtt closed this as completed May 4, 2021
@rekmarks rekmarks reopened this May 4, 2021
@rekmarks rekmarks changed the title "Unreleased" link broken "Unreleased" link disagrees with Prettier style May 4, 2021
@rekmarks rekmarks changed the title "Unreleased" link disagrees with Prettier style "Unreleased" link broken May 4, 2021
@rekmarks rekmarks closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants