Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibilities with some markdownlint rules #60

Closed
rekmarks opened this issue May 19, 2021 · 3 comments · Fixed by #155
Closed

Incompatibilities with some markdownlint rules #60

rekmarks opened this issue May 19, 2021 · 3 comments · Fixed by #155

Comments

@rekmarks
Copy link
Member

This package produces CHANGELOG.md files that are incompatible with markdownlint.

The written changelog conforms exactly to the example from the Keep a Changelog website, but are its spacing conventions really relevant to the spec our our ability to parse a changelog?

I believe that the spacing is irrelevant to the Keep a Changelog spec, and we should make the output changelogs compatible with markdownlint at least in terms of spacing. There may even be an argument to integrate markdownlint into this tool, but that's a different question.

Related: #50. markdownlint-compatibility appears to be largely equivalent with Prettier-compatibility.

@Gudahtt
Copy link
Member

Gudahtt commented May 19, 2021

It is not incompatible - it just doesn't conform exactly to the default ruleset. It seems to work fine if you adjust the blanks-around-headers rule to no longer require any lines below.

@Gudahtt
Copy link
Member

Gudahtt commented May 19, 2021

Changing the spacing, or some other unimportant aspect of the changelog format, is something we could do. But then it wouldn't be strictly compatible with the KeepAChangelog example changelog, and thus with other KeepAChangelog-related tooling. We could make it flexible, but then it would be less useful, because it can't apply the format for us automatically if it's flexible enough to accept both.

@rekmarks rekmarks changed the title Incompatibilities with Markdownlint Incompatibilities with some markdownlint rules May 19, 2021
@danroc
Copy link
Contributor

danroc commented Sep 13, 2023

Update: Keep a Changelog has changed its own changelog file to match markdownlint defaults.

See: olivierlacan/keep-a-changelog#318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants