Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Remove isomorphic-fetch #1106

Merged
merged 4 commits into from
Feb 17, 2023
Merged

BREAKING: Remove isomorphic-fetch #1106

merged 4 commits into from
Feb 17, 2023

Conversation

FrederikBolding
Copy link
Member

Description

Removes usage of isomorphic-fetch in all controller packages.

  • BREAKING:
  • Removed isomorphic-fetch from all packages
    • Consumers must now import isomorphic-fetch or another polyfill themselves if they are running in an environment without fetch

@hmalik88 hmalik88 marked this pull request as ready for review February 17, 2023 17:15
@hmalik88 hmalik88 requested a review from a team as a code owner February 17, 2023 17:15
@hmalik88 hmalik88 merged commit 5f027d6 into main Feb 17, 2023
@hmalik88 hmalik88 deleted the fb/remove-isomorphic-fetch branch February 17, 2023 17:26
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Remove isomorphic-fetch from controllers-utils

* Remove other instances of isomorphic-fetch

* Remove setup  file

* restore test setup file

---------

Co-authored-by: hmalik88 <hassan.malik@consensys.net>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Remove isomorphic-fetch from controllers-utils

* Remove other instances of isomorphic-fetch

* Remove setup  file

* restore test setup file

---------

Co-authored-by: hmalik88 <hassan.malik@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants