Add approval controller count methods #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Adds two methods to the approval controller: - `getTotalApprovalCount`, for getting the total count of all approvals, regardless of origin and type - `getApprovalCount`, for getting the count of all approvals by origin, type, or both
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Adds two methods to the approval controller: - `getTotalApprovalCount`, for getting the total count of all approvals, regardless of origin and type - `getApprovalCount`, for getting the count of all approvals by origin, type, or both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two methods to the approval controller:
getTotalApprovalCount, for getting the total count of all approvals, regardless of origin and typegetApprovalCount, for getting the count of all approvals by origin, type, or bothWe need this for e.g. the the
updateBadgefunctionality in the MetaMask extension. Implementing the methods on the controller itself is better than hacking it on at the consumer layer.