Add default type and timestamps to approval controller #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
approved these changes
Nov 18, 2020
|
I'm having trouble understanding what this "default approval type" is for. Why would we want a default approval type? What should this be set to for the extension Approval controller? Adding any approval without an explicit type sounds like a disaster. I would prefer that an error be thrown upon any attempt to add an approval without a type. |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Add approval controller request times * Fix ApprovalInfo interface documentation * Fix some docstrings * Remove NO_TYPE, add consumer-specifed default type * Rename ApprovalInfo interface to Approval * Fix some docstrings * Fix _validateAddParams bugs
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Add approval controller request times * Fix ApprovalInfo interface documentation * Fix some docstrings * Remove NO_TYPE, add consumer-specifed default type * Rename ApprovalInfo interface to Approval * Fix some docstrings * Fix _validateAddParams bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_TYPEwith a user-specified default type.ApprovalController.haslookups bytypeonly, not justoriginandtype.Date.now()timestamps to approvals.ApprovalInfointerface toApproval_validateAddParams(origin type check too loose)(1) The internal
NO_TYPEadded complexity to the implementation and API for virtually no benefit. This PR replaces this internal type with a user-specified default type. All stored approvals will now have a stringtypeassociated with them. In addition, (2) this PR fixes an oversight with theApprovalController.hasmethod, namely that there was no way to look up pending approvals bytypeonly. These changes are breaking.3 is because it may be useful to know when requests were created, e.g. for sorting. 4 is because why not, 1 and 2 are already breaking. 5 is because, we're already here.