Account tracker improvement #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickycodes will review this PR, and include this in upcoming controllers release |
rickycodes
previously approved these changes
Feb 4, 2021
rickycodes
force-pushed
the
account-tracker
branch
from
93b8360
to
527304b
Compare
rickycodes
approved these changes
Feb 4, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* fix * test * test * prettier * log * safelyExecuteWithTimeouttest * format
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* fix * test * test * prettier * log * safelyExecuteWithTimeouttest * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 issues on the
AccountTrackerControllerethjs-queryonly on this controller, I moved toeth-querysince it was used for other controllers, including the extension's controllersgetBalancecalls were stuck, making the polling process of this controller a heavy process. If thegetBalancecall was stuck, the controller never dropped it and since that process is every 500ms, made the mobile app behave poorly, specially on android. Now if the response doesn't get in time, thegetBalancecall will be dismissed and it will continue to the next poll iteration usingsafelyExecuteWithTimeout.There's also a new util
querythat was on theTransactionControllerbut now is used inAccountTrackerControllertoo, so I made it one.