Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base Controller v2 #358

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Add Base Controller v2 #358

merged 2 commits into from
Feb 23, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 19, 2021

This is the new base controller we'll be transitioning to as part of the controller redesign (#337). It has been added as a separate module so that we can transition each controller more easily, one at a time.

Additional features will be added in future PRs (e.g. schema, messaging).

@Gudahtt Gudahtt requested a review from a team as a code owner February 19, 2021 15:16
@Gudahtt Gudahtt force-pushed the base-controller-v2 branch 5 times, most recently from e8fba64 to 3c7706b Compare February 19, 2021 18:22
This is the new base controller we'll be transitioning to as part of
the controller redesign (#337). It has been added as a separate module
so that we can transition each controller more easily, one at a time.

Additional features will be added in future PRs (e.g. schema,
messaging).
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 LGTM

@Gudahtt Gudahtt merged commit ded054c into develop Feb 23, 2021
@Gudahtt Gudahtt deleted the base-controller-v2 branch February 23, 2021 19:14
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
This is the new base controller we'll be transitioning to as part of
the controller redesign (#337). It has been added as a separate module
so that we can transition each controller more easily, one at a time.

Additional features will be added in future PRs (e.g. schema,
messaging).
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
This is the new base controller we'll be transitioning to as part of
the controller redesign (#337). It has been added as a separate module
so that we can transition each controller more easily, one at a time.

Additional features will be added in future PRs (e.g. schema,
messaging).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants