Add missing dependency and disallow extraneous requires #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `node/no-extraneous-require` and `import/no-extraneous-dependencies` rules have been re-enabled. The one violation was `ethereumjs-tx`, which is a module we are using that wasn't listed among our dependencies. It has been added, using the version that was being used in practice via another dependency (which was v1.3.7).
Gudahtt
force-pushed
the
disallow-extraneous-requires
branch
from
99d06ad
to
64f21d9
Compare
brad-decker
approved these changes
Mar 15, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `node/no-extraneous-require` and `import/no-extraneous-dependencies` rules have been re-enabled. The one violation was `ethereumjs-tx`, which is a module we are using that wasn't listed among our dependencies. It has been added, using the version that was being used in practice via another dependency (which was v1.3.7).
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `node/no-extraneous-require` and `import/no-extraneous-dependencies` rules have been re-enabled. The one violation was `ethereumjs-tx`, which is a module we are using that wasn't listed among our dependencies. It has been added, using the version that was being used in practice via another dependency (which was v1.3.7).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
node/no-extraneous-requireandimport/no-extraneous-dependenciesrules have been re-enabled. The one violation wasethereumjs-tx, which is a module we are using that wasn't listed among our dependencies. It has been added, using the version that was being used in practice via another dependency (which was v1.3.7).