Update selectedAddress when identities are updated
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
update-selected-address-after-updating-identities
branch
from
dd2e506
to
bdc0cc1
Compare
The `selectedAddress` state is now reset to the first identity if the current selected address is removed during an update. This is to ensure the `selectedAddress` is never set to an address that is not present in state. This was already being done manually after each invocation of `updateIdentities` where account removal was anticipated. For mobile this is mostly a non-functional change, except that now this update happens in a single state update rather than over the course of two successive updates.
Gudahtt
force-pushed
the
update-selected-address-after-updating-identities
branch
from
bdc0cc1
to
f1fc179
Compare
brad-decker
approved these changes
Mar 19, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `selectedAddress` state is now reset to the first identity if the current selected address is removed during an update. This is to ensure the `selectedAddress` is never set to an address that is not present in state. This was already being done manually after each invocation of `updateIdentities` where account removal was anticipated. For mobile this is mostly a non-functional change, except that now this update happens in a single state update rather than over the course of two successive updates.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `selectedAddress` state is now reset to the first identity if the current selected address is removed during an update. This is to ensure the `selectedAddress` is never set to an address that is not present in state. This was already being done manually after each invocation of `updateIdentities` where account removal was anticipated. For mobile this is mostly a non-functional change, except that now this update happens in a single state update rather than over the course of two successive updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
selectedAddressstate is now reset to the first identity if the current selected address is removed during an update. This is to ensure theselectedAddressis never set to an address that is not present in state.This was already being done manually after each invocation of
updateIdentitieswhere account removal was anticipated. For mobile this is mostly a non-functional change, except that now this update happens in a single state update rather than over the course of two successive updates.