Restore BN export
#428
Merged
Restore BN export
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BN` export was removed in #398. I hadn't anticipated at the time that this would constitute a breaking change. It turns out that this export was relied upon in mobile in one place. It has been temporarily restored, along with a comment that suggests we remove it in the next major version.
|
Here's where I found it being used: https://github.com/MetaMask/metamask-mobile/pull/2416/files#r599951773 |
rickycodes
approved these changes
Mar 23, 2021
we should definitely fix that. |
rickycodes
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Mar 24, 2021
As mentioned in MetaMask/core#428 the `BN` export was removed in MetaMask/core#398. This is the only instance where it's being imported this way. We should update this now as the `BN` export will be removed from `controllers` in a future version.
rickycodes
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Mar 25, 2021
As mentioned in MetaMask/core#428 the `BN` export was removed in MetaMask/core#398. This is the only instance where it's being imported this way. We should update this now as the `BN` export will be removed from `controllers` in a future version.
cronny25
pushed a commit
to cronny25/metamask-mobile
that referenced
this pull request
Jul 27, 2022
As mentioned in MetaMask/core#428 the `BN` export was removed in MetaMask/core#398. This is the only instance where it's being imported this way. We should update this now as the `BN` export will be removed from `controllers` in a future version.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `BN` export was removed in #398. I hadn't anticipated at the time that this would constitute a breaking change. It turns out that this export was relied upon in mobile in one place. It has been temporarily restored, along with a comment that suggests we remove it in the next major version.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `BN` export was removed in #398. I hadn't anticipated at the time that this would constitute a breaking change. It turns out that this export was relied upon in mobile in one place. It has been temporarily restored, along with a comment that suggests we remove it in the next major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BNexport was removed in #398. I hadn't anticipated at the time that this would constitute a breaking change. It turns out that this export was relied upon in mobile in one place.It has been temporarily restored, along with a comment that suggests we remove it in the next major version.