Feature/upgrade ethereumjs util #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/MetaMask/controllers/blob/f421f1ed1b5e70a4a2a224569e49f77e8bc0b53a/src/util.ts#L284 this line would previously return false for input such as '0000000000000000000000000000000000000000' (non prefixed hex string) and now will throw an error. I highly, highly, highly recommend not using this method directly and instead use a helper method that does something like this one: which I created to get around the numerous breaking changes this introduced and going on our third hotfix for 9.5.3 |
rickycodes
force-pushed
the
feature/upgrade-ethereumjs-util
branch
from
d2f5f85
to
b6643c0
Compare
rickycodes
force-pushed
the
feature/upgrade-ethereumjs-util
branch
2 times, most recently
from
c7edfba
to
481a9d7
Compare
brad-decker
suggested changes
May 25, 2021
rickycodes
force-pushed
the
feature/upgrade-ethereumjs-util
branch
from
0894768
to
c8136ee
Compare
…e/upgrade-ethereumjs-util * 'develop' of github.com:MetaMask/controllers: v10.0.0 (#477)
brad-decker
approved these changes
May 27, 2021
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
ethereumjs-utiltolatestMost of the changes are related to the fact that the addresses we used previously are now considered invalid (they were always invalid, but
ethUtilnow throws in cases where they are).