Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abort-controller polyfill #575

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Add abort-controller polyfill #575

merged 2 commits into from
Aug 31, 2021

Conversation

adonesky1
Copy link
Contributor

Add abort-controller polyfill

Description

  • FIXED:

    • Add abort-controller polyfill, which fixes the broken contract in release v15.0.0 where we introduced a use of AbortController without updating the node engine requirement in package.json to atleast node v15.0.0 where support for AbortController was added.

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

abort-controller excludes its shim / polyfill in the browser (see here). When we add this to the extension, I think we should remove abortcontroller-polyfill from its production dependencies, because all of our supported browsers ship it (see here).

@Gudahtt
Copy link
Member

Gudahtt commented Aug 31, 2021

We support Chromium version 63 and above, but AbortController wasn't added until version 66. So I don't think we can remove the polyfill from the extension without dropping support for those versions.

@rekmarks
Copy link
Member

rekmarks commented Aug 31, 2021

We support Chromium version 63 and above, but AbortController wasn't added until version 66. So I don't think we can remove the polyfill from the extension without dropping support for those versions.

For reference, here's browser usage for Chromium as of today:

npx browserslist '>= 0.25%'

chrome 92
chrome 91
chrome 90
chrome 87
edge 92
edge 91

@adonesky1 adonesky1 merged commit b899032 into main Aug 31, 2021
@adonesky1 adonesky1 deleted the abort-controller-polyfill branch August 31, 2021 20:55
@adonesky1 adonesky1 mentioned this pull request Aug 31, 2021
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants