Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Favorite Collectibles #623

Merged
merged 15 commits into from
Dec 6, 2021
Merged

[FEAT] Favorite Collectibles #623

merged 15 commits into from
Dec 6, 2021

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Nov 4, 2021

Description

Feature to allow the user to set a collectible as favorite. This logic was implemented in the mobile app layer, but for simplicity it was decided to move it to the controllers layer.

Tasks

  • Develop "Favorite" logic
  • Add test cases
  • Update unit tests

References

@gantunesr gantunesr requested a review from a team November 4, 2021 01:23
@gantunesr gantunesr self-assigned this Nov 4, 2021
@wachunei
Copy link
Member

wachunei commented Dec 2, 2021

Since we are adding the collectible by using addCollectible and fetching metadata that could potentially change, I suggest we just expect to match the constants we need to test { address, tokenId, favorite }

Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gantunesr gantunesr merged commit 53775d9 into main Dec 6, 2021
@gantunesr gantunesr deleted the feat/favorites-nft branch December 6, 2021 15:57
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants