Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix polling initialization for collectibles #662

Merged
merged 2 commits into from
Dec 13, 2021
Merged

fix polling initialization for collectibles #662

merged 2 commits into from
Dec 13, 2021

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Dec 10, 2021 •
edited
Loading

  • FIXED:
    • The useCollectibleDetection state field passed into the CollectibleDetectionController via the onPreferencesChange method should, when toggled from false to true, call the start method instead of the detectCollectibles method. Additionally when this state is flipped from true to false it should call stop.

@adonesky1 adonesky1 requested a review from a team as a code owner December 10, 2021 23:14
gantunesr
gantunesr previously approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wachunei
wachunei approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 merged commit 09a1ea6 into main Dec 13, 2021
@adonesky1 adonesky1 deleted the fix/asset-polling branch December 13, 2021 16:16
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
fix polling initialization for collectibles (#662)
a595f8f
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
fix polling initialization for collectibles (#662)
462b341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wachunei wachunei wachunei approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adonesky1 @wachunei @gantunesr