-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId #672
Merged
adonesky1
merged 3 commits into
main
from
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
Jan 7, 2022
Merged
Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId #672
adonesky1
merged 3 commits into
main
from
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
Jan 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
branch
from
January 6, 2022 19:50
e7b27cb
to
b91e203
Compare
…sed accountParams for selectedAddress and chainId
adonesky1
force-pushed
the
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
branch
from
January 6, 2022 19:50
b91e203
to
cf8d2a3
Compare
adonesky1
changed the title
Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use pas…
Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId
Jan 6, 2022
mcmire
previously approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few nits, but this seems kosher to me 👍🏻
mcmire
approved these changes
Jan 7, 2022
gantunesr
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adonesky1
deleted the
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
branch
January 7, 2022 17:21
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…sed accountParams for selectedAddress and chainId (#672) * Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…sed accountParams for selectedAddress and chainId (#672) * Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADDED:
accountParams
(an object containing auserAddress
andchainId
) to methodcheckAndUpdateSingleCollectibleOwnershipStatus
, which when uses the passeduserAddress
andchainId
to find the collectible that should be updated.