Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId #672

Merged

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Jan 6, 2022

  • ADDED:

    • Adds an optional parameter accountParams (an object containing a userAddress and chainId) to method checkAndUpdateSingleCollectibleOwnershipStatus, which when uses the passed userAddress and chainId to find the collectible that should be updated.

@adonesky1 adonesky1 force-pushed the enhance-checkAndUpdateSingleCollectibleOwnershipStatus branch from e7b27cb to b91e203 Compare January 6, 2022 19:50
…sed accountParams for selectedAddress and chainId
@adonesky1 adonesky1 force-pushed the enhance-checkAndUpdateSingleCollectibleOwnershipStatus branch from b91e203 to cf8d2a3 Compare January 6, 2022 19:50
@adonesky1 adonesky1 changed the title Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use pas… Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId Jan 6, 2022
@adonesky1 adonesky1 marked this pull request as ready for review January 6, 2022 21:21
@adonesky1 adonesky1 requested a review from a team as a code owner January 6, 2022 21:21
mcmire
mcmire previously approved these changes Jan 6, 2022
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few nits, but this seems kosher to me 👍🏻

src/assets/CollectiblesController.ts Outdated Show resolved Hide resolved
src/assets/CollectiblesController.ts Outdated Show resolved Hide resolved
src/assets/CollectiblesController.ts Outdated Show resolved Hide resolved
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 merged commit d7ec98b into main Jan 7, 2022
@adonesky1 adonesky1 deleted the enhance-checkAndUpdateSingleCollectibleOwnershipStatus branch January 7, 2022 17:21
@adonesky1 adonesky1 mentioned this pull request Jan 10, 2022
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
…sed accountParams for selectedAddress and chainId (#672)

* Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
…sed accountParams for selectedAddress and chainId (#672)

* Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants