Fix RateLimitController aggressive timeout issue #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
reviewed
Mar 10, 2022
Comment on lines
+172
to
+180
| const previous = (state as any).requests[api][origin] ?? 0; | ||
| (state as any).requests[api][origin] = previous + 1; | ||
|
|
||
| if (previous === 0) { | ||
| setTimeout( | ||
| () => this.resetRequestCount(api, origin), | ||
| this.rateLimitTimeout, | ||
| ); | ||
| } |
There was a problem hiding this comment.
If the intended behavior is that the first request initiates a timeout, during which the requesting origin can make no more than rateLimitCount number of requests, then my late-night brain assesses that this is correct.
Previously, every request would initiate a new timeout, regardless of whether the previous one had expired, and that's definitely not correct.
There was a problem hiding this comment.
That's exactly the conclusion that I came to as well, your described behaviour was the intention, but it may been altered throughout the implementation process without a good test to remind me. That should be corrected with this PR. Feel free to wait for tomorrow to do an actual review 😄
mcmire
approved these changes
Mar 10, 2022
soralit
pushed a commit
to KeystoneHQ/controllers
that referenced
this pull request
Mar 14, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue with RateLimitController where we applied the timeout too aggressively
Checklist