Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PermissionController.revokePermissionForAllSubjects action #764

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Apr 6, 2022

Adds a controller messenger action for PermissionController.revokePermissionForAllSubjects. We currently call the underlying function directly in the extension, but we'd like to encapsulate that call in the SnapController, which is where it should occur.

@rekmarks rekmarks requested a review from a team as a code owner April 6, 2022 23:59
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 3391089 into main Apr 7, 2022
@rekmarks rekmarks deleted the revokePermissionForAllSubjects-action branch April 7, 2022 19:15
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Adds a controller messenger action for `PermissionController.revokePermissionForAllSubjects`. We currently call the underlying function directly in the extension, but we'd like to encapsulate that call in the `SnapController`, which is where it should occur.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Adds a controller messenger action for `PermissionController.revokePermissionForAllSubjects`. We currently call the underlying function directly in the extension, but we'd like to encapsulate that call in the `SnapController`, which is where it should occur.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants