Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eth-keyring-controller to 7.0.1 #802

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Bump eth-keyring-controller to 7.0.1 #802

merged 1 commit into from
Apr 26, 2022

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Apr 25, 2022 •
edited
Loading

Bump eth-keyring-controller to 7.0.1. Adapt tests accordingly.

@adonesky1 adonesky1 force-pushed the bump-keyringcontroller-version branch from 4bb8039 to c101c4e Compare April 26, 2022 16:59
@adonesky1 adonesky1 marked this pull request as ready for review April 26, 2022 17:00
@adonesky1 adonesky1 requested a review from a team as a code owner April 26, 2022 17:00
@adonesky1 adonesky1 changed the title Bump keyringcontroller version Bump eth-keyring-controller to 7.0.1 Apr 26, 2022
Gudahtt
Gudahtt approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But this should be documented as a breaking change because the vault serialization format has changed. Worth calling out because it will affect mobile.

@adonesky1 adonesky1 merged commit 5105fd5 into main Apr 26, 2022
@adonesky1 adonesky1 deleted the bump-keyringcontroller-version branch April 26, 2022 17:30
@adonesky1 adonesky1 mentioned this pull request May 3, 2022
Merged
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
bump eth-keyring-controller to 7.0.1 + Adapt tests accordingly (#802)
007f329
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
bump eth-keyring-controller to 7.0.1 + Adapt tests accordingly (#802)
c1ca08a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire Awaiting requested review from mcmire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adonesky1 @Gudahtt