-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetworkController API normalization: Add rollbackToPreviousProvider
method.
#1024
Comments
I realize this might be out of scope for this issue, but since |
That would make sense to me! The way in which we roll back is an internal implementation detail, we don't need it to match the extension. And for the previous provider state, we don't need to store that as controller state at all. I had planned on removing it from the extension (in this PR) since we don't use it anywhere except in the implementation of this method. |
Ah yea we don't need it persisted to localStorage since its only ever relevant when attempting to change networks. |
We should add a method for rolling back to the previous provider config. This can be useful for handling connection failures when switching to a network.
This is part of a larger effort to normalize the API of both network controllers, to make them easier to merge.
The text was updated successfully, but these errors were encountered: