-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keyring-controller] addAccountWithoutUpdate
now updates the PreferencesController
state
#3848
Comments
Maybe we can remove this method instead of fixing it. Will investigate if it's still needed. It was added originally for this mobile feature: MetaMask/metamask-mobile#1879 Alternatively, we could update the keyring API to add a method that returns the next account address without adding it. That would solve the problem as well. |
@Gudahtt This could be similar to what also hardware keyrings currently do with Perhaps we could think of a way to standardise that and add it to the general Keyring API? It might be a way to fix this issue while also making the Hardware keyrings easier to use, and a bit more aligned with how other keyrings work |
Good point, yes it's exactly like that |
@Gudahtt has offered to test on mobile to determine if the method is even needed. |
@Gudahtt Regardless of the test I think we can close this and simply remove the method: |
This method was intended just to avoid updating |
@mikesposito @Gudahtt Just checking, is this ticket still relevant? |
We believe this isn't an issue but we should verify and close. |
I opened a PR on mobile to stop using this method in favor of a more efficient solution: MetaMask/metamask-mobile#11409 We can proceed to remove the method from |
The
KeyringController
methodaddAccountWithoutUpdate
no longer works; it does add the account, but not without updating state to include thew new account.This was broken in
@metamask/preferences-controller@7.0.0
The text was updated successfully, but these errors were encountered: