Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra slash when constructing user storage url #4702

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

dovydas55
Copy link
Contributor

@dovydas55 dovydas55 commented Sep 13, 2024

Explanation

This PR solves the bug of adding extra slash when user storage url is generated

References

Changelog

@metamask/profile-sync-controller

  • FIXED: remove extra slash when constructing user storage url

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@dovydas55 dovydas55 requested a review from a team as a code owner September 13, 2024 15:25
@dovydas55 dovydas55 self-assigned this Sep 13, 2024
@dovydas55
Copy link
Contributor Author

@metamaskbot publish-preview

1 similar comment
@dovydas55
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.0-preview-367cb1da",
  "@metamask-previews/address-book-controller": "6.0.0-preview-367cb1da",
  "@metamask-previews/announcement-controller": "7.0.0-preview-367cb1da",
  "@metamask-previews/approval-controller": "7.0.3-preview-367cb1da",
  "@metamask-previews/assets-controllers": "38.0.0-preview-367cb1da",
  "@metamask-previews/base-controller": "7.0.0-preview-367cb1da",
  "@metamask-previews/build-utils": "3.0.0-preview-367cb1da",
  "@metamask-previews/chain-controller": "0.1.1-preview-367cb1da",
  "@metamask-previews/composable-controller": "9.0.0-preview-367cb1da",
  "@metamask-previews/controller-utils": "11.2.0-preview-367cb1da",
  "@metamask-previews/ens-controller": "14.0.0-preview-367cb1da",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-367cb1da",
  "@metamask-previews/gas-fee-controller": "20.0.0-preview-367cb1da",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-367cb1da",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-367cb1da",
  "@metamask-previews/keyring-controller": "17.2.0-preview-367cb1da",
  "@metamask-previews/logging-controller": "6.0.0-preview-367cb1da",
  "@metamask-previews/message-manager": "10.1.0-preview-367cb1da",
  "@metamask-previews/name-controller": "8.0.0-preview-367cb1da",
  "@metamask-previews/network-controller": "21.0.0-preview-367cb1da",
  "@metamask-previews/notification-controller": "6.0.0-preview-367cb1da",
  "@metamask-previews/notification-services-controller": "0.5.0-preview-367cb1da",
  "@metamask-previews/permission-controller": "11.0.1-preview-367cb1da",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-367cb1da",
  "@metamask-previews/phishing-controller": "12.0.2-preview-367cb1da",
  "@metamask-previews/polling-controller": "10.0.0-preview-367cb1da",
  "@metamask-previews/preferences-controller": "13.0.2-preview-367cb1da",
  "@metamask-previews/profile-sync-controller": "0.5.0-preview-367cb1da",
  "@metamask-previews/queued-request-controller": "5.0.0-preview-367cb1da",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-367cb1da",
  "@metamask-previews/selected-network-controller": "18.0.0-preview-367cb1da",
  "@metamask-previews/signature-controller": "19.0.0-preview-367cb1da",
  "@metamask-previews/transaction-controller": "36.1.0-preview-367cb1da",
  "@metamask-previews/user-operation-controller": "15.0.0-preview-367cb1da"
}

@mathieuartu
Copy link
Contributor

@metamaskbot publish-preview

@mathieuartu mathieuartu changed the title Notify 589 auth v2 fix: remove extra slash when constructing user storage url Sep 13, 2024
@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Sep 13, 2024
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.0-preview-9edcf0e0",
  "@metamask-previews/address-book-controller": "6.0.0-preview-9edcf0e0",
  "@metamask-previews/announcement-controller": "7.0.0-preview-9edcf0e0",
  "@metamask-previews/approval-controller": "7.0.3-preview-9edcf0e0",
  "@metamask-previews/assets-controllers": "38.0.0-preview-9edcf0e0",
  "@metamask-previews/base-controller": "7.0.0-preview-9edcf0e0",
  "@metamask-previews/build-utils": "3.0.0-preview-9edcf0e0",
  "@metamask-previews/chain-controller": "0.1.1-preview-9edcf0e0",
  "@metamask-previews/composable-controller": "9.0.0-preview-9edcf0e0",
  "@metamask-previews/controller-utils": "11.2.0-preview-9edcf0e0",
  "@metamask-previews/ens-controller": "14.0.0-preview-9edcf0e0",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-9edcf0e0",
  "@metamask-previews/gas-fee-controller": "20.0.0-preview-9edcf0e0",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-9edcf0e0",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-9edcf0e0",
  "@metamask-previews/keyring-controller": "17.2.0-preview-9edcf0e0",
  "@metamask-previews/logging-controller": "6.0.0-preview-9edcf0e0",
  "@metamask-previews/message-manager": "10.1.0-preview-9edcf0e0",
  "@metamask-previews/name-controller": "8.0.0-preview-9edcf0e0",
  "@metamask-previews/network-controller": "21.0.0-preview-9edcf0e0",
  "@metamask-previews/notification-controller": "6.0.0-preview-9edcf0e0",
  "@metamask-previews/notification-services-controller": "0.5.0-preview-9edcf0e0",
  "@metamask-previews/permission-controller": "11.0.1-preview-9edcf0e0",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-9edcf0e0",
  "@metamask-previews/phishing-controller": "12.0.2-preview-9edcf0e0",
  "@metamask-previews/polling-controller": "10.0.0-preview-9edcf0e0",
  "@metamask-previews/preferences-controller": "13.0.2-preview-9edcf0e0",
  "@metamask-previews/profile-sync-controller": "0.5.0-preview-9edcf0e0",
  "@metamask-previews/queued-request-controller": "5.0.0-preview-9edcf0e0",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-9edcf0e0",
  "@metamask-previews/selected-network-controller": "18.0.0-preview-9edcf0e0",
  "@metamask-previews/signature-controller": "19.0.0-preview-9edcf0e0",
  "@metamask-previews/transaction-controller": "36.1.0-preview-9edcf0e0",
  "@metamask-previews/user-operation-controller": "15.0.0-preview-9edcf0e0"
}

Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dovydas55 dovydas55 merged commit 57a722e into main Sep 13, 2024
117 checks passed
@dovydas55 dovydas55 deleted the NOTIFY-589-auth-v2 branch September 13, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants