Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Etherscan API keys #4748

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Conversation

matthewwalsh0
Copy link
Member

Explanation

Support the use of API keys when polling for incoming transactions in the TransactionController.

Provided by the client via the optional incomingTransactions.etherscanApiKeysByChainId property, since API keys may be exclusive to specific chains, based on the Etherscan host / domain.

References

Changelog

@metamask/transaction-controller

  • ADDED: Add optional incomingTransactions.etherscanApiKeysByChainId constructor property to support API keys in requests to Etherscan.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner October 1, 2024 07:51
@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-3940b6ca",
  "@metamask-previews/address-book-controller": "6.0.1-preview-3940b6ca",
  "@metamask-previews/announcement-controller": "7.0.1-preview-3940b6ca",
  "@metamask-previews/approval-controller": "7.1.0-preview-3940b6ca",
  "@metamask-previews/assets-controllers": "38.1.0-preview-3940b6ca",
  "@metamask-previews/base-controller": "7.0.1-preview-3940b6ca",
  "@metamask-previews/build-utils": "3.0.1-preview-3940b6ca",
  "@metamask-previews/chain-controller": "0.1.3-preview-3940b6ca",
  "@metamask-previews/composable-controller": "9.0.1-preview-3940b6ca",
  "@metamask-previews/controller-utils": "11.3.0-preview-3940b6ca",
  "@metamask-previews/ens-controller": "14.0.1-preview-3940b6ca",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-3940b6ca",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-3940b6ca",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-3940b6ca",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-3940b6ca",
  "@metamask-previews/keyring-controller": "17.2.2-preview-3940b6ca",
  "@metamask-previews/logging-controller": "6.0.1-preview-3940b6ca",
  "@metamask-previews/message-manager": "10.1.1-preview-3940b6ca",
  "@metamask-previews/name-controller": "8.0.1-preview-3940b6ca",
  "@metamask-previews/network-controller": "21.0.1-preview-3940b6ca",
  "@metamask-previews/notification-controller": "7.0.0-preview-3940b6ca",
  "@metamask-previews/notification-services-controller": "0.8.1-preview-3940b6ca",
  "@metamask-previews/permission-controller": "11.0.2-preview-3940b6ca",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-3940b6ca",
  "@metamask-previews/phishing-controller": "12.0.3-preview-3940b6ca",
  "@metamask-previews/polling-controller": "10.0.1-preview-3940b6ca",
  "@metamask-previews/preferences-controller": "13.0.3-preview-3940b6ca",
  "@metamask-previews/profile-sync-controller": "0.9.3-preview-3940b6ca",
  "@metamask-previews/queued-request-controller": "5.1.0-preview-3940b6ca",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-3940b6ca",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-3940b6ca",
  "@metamask-previews/signature-controller": "19.1.0-preview-3940b6ca",
  "@metamask-previews/transaction-controller": "37.1.0-preview-3940b6ca",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-3940b6ca"
}

@matthewwalsh0 matthewwalsh0 merged commit c2845d1 into main Oct 1, 2024
116 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/etherscan-api-key branch October 1, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants