Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/175.0.0 #4525

Merged
merged 10 commits into from
Jul 16, 2024
Merged

Release/175.0.0 #4525

merged 10 commits into from
Jul 16, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jul 15, 2024 •
edited
Loading

Explanation

Releases assets-controllers to new version 36.0.0

References

Changelog

@metamask/assets-controllers

Added

  • Added: Add optional topBid property to the NftMetadata type. This property must be of type TopBid. (#4522)
  • Added: Add optional floorAsk property to the TokenCollection type. This property must be of type FloorAskCollection. (#4522)
  • Added: Add linea mainnet support to nft detection supported networks (#4515)
  • Added: Fetch NFT collections data from the NFT-API getCollections API when calling the detectNfts method of NftDetectionController, and the updateNftMetadata and watchNft methods of NftController. (#4443)

Changed

  • Changed: Bump @metamask/utils to ^9.0.0 (#4508)
  • Changed: Bump @metamask/rpc-errors to ^6.3.1 (#4498)

Fixed

  • Breaking: Changed attributes type in NftMetadata to Attributes[] (#4522)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@sahar-fehri sahar-fehri requested a review from a team as a code owner July 15, 2024 13:18
@sahar-fehri sahar-fehri requested a review from a team July 15, 2024 13:27
mcmire
mcmire reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job creating this release! I just had a few suggestions.

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/package.json Outdated Show resolved Hide resolved
cryptodev-2s
cryptodev-2s previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahar-fehri sahar-fehri requested a review from MajorLift July 15, 2024 18:55
@sahar-fehri sahar-fehri requested a review from MajorLift July 15, 2024 20:55
MajorLift
MajorLift approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@MajorLift MajorLift left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your patience with all the requests and questions.

@sahar-fehri sahar-fehri merged commit 8768a17 into main Jul 16, 2024
116 checks passed
@sahar-fehri sahar-fehri deleted the release/175.0.0 branch July 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire left review comments

@MajorLift MajorLift MajorLift approved these changes

@cryptodev-2s cryptodev-2s cryptodev-2s left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sahar-fehri @mcmire @MajorLift @cryptodev-2s