Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify last release tag name for core subpackages #105

Closed
MajorLift opened this issue Nov 7, 2023 · 1 comment
Closed
Assignees
Labels

Comments

@MajorLift
Copy link
Contributor

Currently, this tool is set to assume that tag names will be in the @metamask/ namespace, when searching for the last release tag of a subpackage.

With packages that are being migrated into the core monorepo, this is not always the case, especially if they are set to be renamed into the @metamask/ namespace after their migration.

To handle these edge cases, we need to expose an option in the create-release-branch cli that will let us specify the last release tag name for a given subpackage, so that the tool can properly examine the diff between the specified tag and HEAD.

@MajorLift
Copy link
Contributor Author

This issue can be sidestepped by adding a CHANGELOG entry for the next release version before running create-release-branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant