Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fetch] Update list of retriable errors #212

Open
Gudahtt opened this issue Jun 15, 2023 · 1 comment
Open

[fetch] Update list of retriable errors #212

Gudahtt opened this issue Jun 15, 2023 · 1 comment

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Jun 15, 2023

We should analyze errors that we're seeing in production, and update our list of retriable errors to include all expected transient error scenarios.

We may need to improve the "retriable error" detection to consider more than just the message. For example, we may want to take into consideration the response headers or status code as well.

@mcmire
Copy link
Contributor

mcmire commented Jul 18, 2024

Additional thoughts: Currently we handle 418 as a rate limit error. Perhaps we should also handle 429 as a rate limit error, and/or treat both 418 and 429 as retriable errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants