Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures broken on popup (v7.5.1) #7427

Closed
jgeary opened this issue Nov 14, 2019 · 1 comment
Closed

Signatures broken on popup (v7.5.1) #7427

jgeary opened this issue Nov 14, 2019 · 1 comment

Comments

@jgeary
Copy link

jgeary commented Nov 14, 2019

Description
The metamask popup is not functional for several signature methods (eth_sign, personal_sign, sign_typed_data v1) for version 7.5.1. Neither the "Sign" button or the "Cancel" button do anything - the popup does not close and no signature is created. For a workaround I have found that if you close the popup, then click the metamask icon to see pending interactions, you can then complete the signature from there. This is a frustration for our users with the most recent version of Metamask.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://danfinlay.github.io/js-eth-personal-sign-examples/ on Chrome (not sure about other browsers)
  2. Click each button
  3. Only Connect, Sign Typed Data V3, and Sign Typed Data V4 have functional popups. The rest have functionless buttons, and can only be completed by the workaround I described above
@tmashuang
Copy link
Contributor

Fixed in #7414. Next version, which can be published to day, will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants