Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify entropy source for snap_getBip44Entropy #923

Open
SebastienGllmt opened this issue Jul 15, 2023 · 1 comment
Open

Clarify entropy source for snap_getBip44Entropy #923

SebastienGllmt opened this issue Jul 15, 2023 · 1 comment
Assignees
Labels
snaps Related to Snaps content. team-snaps-platform

Comments

@SebastienGllmt
Copy link

SebastienGllmt commented Jul 15, 2023

Right now Snaps offers snap_getBip44Entropy and snap_getBip32Entropy. However, It's not mentioned what the source of this entropy is. The documentation seems to indicate that it's the same root entropy the user used when setting up Metamask itself, but I think the source should be clarified given snap_getentropy explicitly states that at least for itself, it's snap-specific entropy

We also do not explain how BIP32 and BIP44 are related or why you should use one or the other.

We also do not explain the pitfall of using an unknown coinType or how to add a coinType to SLIP44

@Montoya
Copy link
Collaborator

Montoya commented Sep 21, 2023

snap_getEntropy is specific to the Snap, snap_getBip44Entropy and snap_getBip32Entropy are not.

@Montoya Montoya closed this as completed Sep 21, 2023
@Montoya Montoya reopened this Sep 21, 2023
@Montoya Montoya transferred this issue from MetaMask/snaps Sep 21, 2023
@alexandratran alexandratran added snaps Related to Snaps content. team-snaps-platform labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snaps Related to Snaps content. team-snaps-platform
Projects
None yet
Development

No branches or pull requests

4 participants