Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add isSecureContext endowment #2893

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 19, 2024

Adds isSecureContext for the browser environments, this will continue to be undefined in the Node.js environment.

Fixes #2890

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (5052aaa) to head (2fa278d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2893   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         486      486           
  Lines       10399    10399           
  Branches     1594     1594           
=======================================
  Hits         9825     9825           
  Misses        574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@FrederikBolding FrederikBolding marked this pull request as ready for review November 19, 2024 11:37
@FrederikBolding FrederikBolding requested a review from a team as a code owner November 19, 2024 11:37
Copy link

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine. I'm also wondering if passing true wouldn't be enough

@FrederikBolding FrederikBolding force-pushed the fb/add-is-secure-context-endowment branch from 87dd64b to 2fa278d Compare November 19, 2024 15:11
@FrederikBolding FrederikBolding merged commit a645d0d into main Nov 19, 2024
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/add-is-secure-context-endowment branch November 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isSecureContext to default endowments
3 participants