Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @metamask/snaps-cli unit tests #74

Closed
1 of 3 tasks
rekmarks opened this issue Sep 6, 2021 · 2 comments
Closed
1 of 3 tasks

Improve @metamask/snaps-cli unit tests #74

rekmarks opened this issue Sep 6, 2021 · 2 comments
Labels
type-enhancement New feature or request

Comments

@rekmarks
Copy link
Member

rekmarks commented Sep 6, 2021

Following MetaMask/snaps-cli#74, there are still some unit test improvements to make:

  • Achieve 100% branch coverage for all files
  • Test the built evalWorker file
  • Test the yargs-generated argv object for all commands
    • See TODO in cli.test.ts
@rekmarks rekmarks transferred this issue from MetaMask/snaps-cli Sep 8, 2021
@rekmarks rekmarks changed the title Improve unit tests snaps-cli: Improve unit tests Sep 8, 2021
@rekmarks rekmarks changed the title snaps-cli: Improve unit tests Improve unit tests Sep 8, 2021
@rekmarks rekmarks added the type-enhancement New feature or request label Jan 20, 2022
@rekmarks
Copy link
Member Author

@hmalik88 how are we doing with this?

@hmalik88
Copy link
Contributor

Haven't got to this issue yet, but it's partially blocked by #556 as that will change worker implementation possibly. We're at 100% coverage minus eval-worker.js, I need to have a chat with Kris from Agoric about testing lockdown (I had a method when working on execution-environments but I'm not sure if that's proper). Will be able to address after NFT NYC week.

@rekmarks rekmarks changed the title Improve unit tests Improve @metamask/snaps-cli unit tests Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants