Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Squeak 4.6 & 5.0 platform attributes and update Travis #364

Merged
merged 3 commits into from
Sep 13, 2015
Merged

add Squeak 4.6 & 5.0 platform attributes and update Travis #364

merged 3 commits into from
Sep 13, 2015

Conversation

pdebruic
Copy link
Collaborator

This is a copy of Tobias's fix to the defaulPlatformAttributes update for Squeak 4.6 & 5.0

I also added Pharo 4, Squeak 4.6 & 5.0 to the .travis.yml file

@dalehenrich
Copy link
Member

@pdebruic looks like we're down to a builderCI issue?:

+case "$ST" in
+IMAGE_BASE_NAME=Squeak-5.0
+IMAGE_TARGET_NAME=Squeak-5.0
+case "$ST" in
+case "$ST" in
+mv Squeak-5.0.changes ../Squeak-5.0.changes
mv: cannot stat `Squeak-5.0.changes': No such file or directory
The command "./build_image.sh" failed and exited with 1 during .

@pdebruic
Copy link
Collaborator Author

@dalehenrich

Yeah I was looking at that and confusing myself. Then I realized you haven't merged the pull request in Builder CI which fixes Squeak 5.0. So do that and these two PRs of mine should fix themselves once you re-trigger them on Travis..

I think.

@dalehenrich
Copy link
Member

... and I've just merged the Squeak5.0 addition to builderCI, so I will restart the two Squeak5.0 builds ...

@pdebruic
Copy link
Collaborator Author

@dalehenrich OK but I think we will need to fix #369 for these to fully pass.

also - Can you restart the build for pr #366 ?

@dalehenrich
Copy link
Member

#366 is restarted ...

On 08/24/2015 11:54 AM, Paul DeBruicker wrote:

@dalehenrich https://github.com/dalehenrich OK but I think we will
need to fix #369
https://github.com/dalehenrich/metacello-work/issues/369 for these
to fully pass.

also - Can you restart the build for pr #366
https://github.com/dalehenrich/metacello-work/pull/366 ?


Reply to this email directly or view it on GitHub
https://github.com/dalehenrich/metacello-work/pull/364#issuecomment-134338151.

@dalehenrich
Copy link
Member

@pdebruic, yes we are down to #369 for Squeak 5.0, so if you fix that bug as part of this PR, the master branch will be ready for prime time ... #366 still seems to be having massive failures and I will need to look at things a bit closer

dalehenrich added a commit that referenced this pull request Sep 13, 2015
add Squeak 4.6 & 5.0 platform attributes and update Travis
@dalehenrich dalehenrich merged commit 36dcaf5 into Metacello:master Sep 13, 2015
@krono
Copy link
Collaborator

krono commented Sep 13, 2015

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants