-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the platform attributes for 4.6 and 5.0 (for Metacello Preview) #366
add the platform attributes for 4.6 and 5.0 (for Metacello Preview) #366
Conversation
It looks like the code for 1.0.0-beta.32.17 is no longer passing - these results do not include your changes ... I suspect tests have changed since then .. so I am seriously considering merging this without passing travis tests ... remind me why I thought that we needed to make these changes:) |
After merging this change we will get a new SHA we can reference in the ConfigurationOfMetacelloPreview (which we will update then all over the place) to ensure that when someone using Squeak 4.6 or 5.0 runs an #ensureMetacello process they get a version of Metacello that knows about the platform attributes for Squeak 4.6 & 5.0. I think its fine to merge because it only affects the platform attributes on Squeak, and the code worksforme..... |
add the platform attributes for 4.6 and 5.0 (for Metacello Preview)
Now I will start work on updating the Configuration ... open an issue for tracking |
We started the configuration on Friday I think. I've got it on my laptop. I'll push it and make a PR. |
Whoops, I made the same edits earlier this afternoon: bda06bf ... seeing lots of test failures on both yours and mine - I assume that the problem is that we're hitting github api rate limits running the tests ... I've been restarting my tests and I think they are passing ... so I'm going to nuke your test run and go with my edits since the tests are further along ... |
Sounds good.
|
patiently waiting :) |
Sorry @krono, I've got a lot of things on my plate right now and if the On 8/28/15 7:02 AM, Tobias Pape wrote:
|
No problem :) I am still on vacation and hence quite unresponsive |
issue #365