Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NO_COLOR environment variable #185

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Support NO_COLOR environment variable #185

merged 2 commits into from
Jun 30, 2024

Conversation

MiSawa
Copy link
Owner

@MiSawa MiSawa commented Jun 30, 2024

Closes #184

  • See: https://no-color.org/
  • -C command line arg takes precedence over NO_COLOR env var, as NO_COLOR is more like a system-wide config and -C arg is specific to the command.
  • Setting NO_COLOR to anything other than the empty string do it currently, as the example implementation in no-color.org do so. I'm open to disable no-color for NO_COLOR=0, please ping me if you want that.

@MiSawa MiSawa merged commit 0653cdf into master Jun 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: NO_COLOR standard implementation
1 participant