Added Docker support for server only mode #673

bastilimbach · 2017-01-31T15:52:37Z

I added a Dockerfile and some additional docker related files to support the deployment of the server only mode using Docker.

@MichMich to make the shell command work you need to create an account at Docker Hub and link this repository to it. So every time the Github Repo gets updated, the Docker Image will be rebuild and updated automatically.

Is it correct to add my changes under the "## [2.1.0] - 2016-12-31" section of the changelog?

Add the change to CHANGELOG.md

roramirez · 2017-01-31T17:29:51Z

README.md

+#### Manual
+
+1. Download and install the latest Node.js version.
+2. Clone the repository and check out the beta branch: `git clone https://github.com/MichMich/MagicMirror`


Should set master branch here not beta.

What do you mean? Where did I use the "beta" branch?

Yes, beta branch isn't use anymore. When you do it a checkout from url is used master branch. Just change the beta by master.

This is change done few days ago
a591cf1

Oh now I see what you mean. Sorry. I just copied it from line 40. Should I change it there too?

roramirez · 2017-01-31T18:01:44Z

README.md

@@ -46,8 +46,41 @@ curl -sL https://raw.githubusercontent.com/MichMich/MagicMirror/master/installer
 **Note:** if you want to debug on Raspberry Pi you can use `npm start dev` which will start the MagicMirror app with Dev Tools enabled.

 ### Server Only
+In some cases, you want to start the application without an actual app window. In this case, you can start MagicMirror² in server only mode. This will start the server, after which you can open the application in your browser of choice.


No remove reference to command node serveronly some users can be not understand how run the mode server only.

roramirez

I like it this change. After this can be take the next step mentioned on forum by @morozgrafix

https://forum.magicmirror.builders/post/12602

There some little things are need to change.

MichMich · 2017-01-31T18:16:00Z

@bastilimbach Please add your changes to the [2.1.1] - Unreleased section of the CHANGELOG. Aso, the change doesn't seem to pass the travis test. Please run grunt to check what's wrong.

Thanks for your contribution!

bastilimbach · 2017-01-31T18:45:32Z

js/defaults.js

@@ -8,7 +8,7 @@
 */

 var defaults = {
-	port: 8080,
+	port: process.env.MM_PORT || 8080,


@MichMich I did run grunt before and couldn't figure out what the problem was. jsLint says there are irregular whitespaces but there aren't any. Or am I completely wrong here?

After MM_PORT there a stranger space. Irregular whitespace. In character 30. Add a normal space.

Strange. But it worked. Thanks 👍

Various whitespace characters can be inputted by programmers by mistake for example from copying or keyboard shortcuts. Pressing Alt + Space on OS X adds in a non breaking space character for example.
http://eslint.org/docs/rules/no-irregular-whitespace

MichMich · 2017-01-31T20:52:06Z

Nice work! Thanks!

morozgrafix · 2017-02-01T00:44:19Z

@bastilimbach Looks like this change is causing black screen on load when starting MM with npm start or node serveronly and following error in the console log of chrome/electron.

Uncaught ReferenceError: process is not defined
    at defaults.js:11
(anonymous) @ defaults.js:11

I believe that culprit is 354b745#diff-75953debd6cf3faf33d4ff10e8353645R11

More details https://forum.magicmirror.builders/post/13221

hotfix PL #673

fewi · 2017-03-02T08:00:39Z

@MichMich to make the shell command work you need to create an account at Docker Hub and link this repository to it. So every time the Github Repo gets updated, the Docker Image will be rebuild and updated automatically.

Any progress on this? Would be nice to get updated Docker images at Docker Hub

bastilimbach · 2017-03-02T08:04:10Z

@fewi Version 2.1.1 isn't released yet. Look at the Changelog. I think with the release of 2.1.1, @MichMich will put the image onto Docker Hub.

MichMich · 2017-03-02T08:22:48Z

@fewi For now you can just use the develop branch.

bastilimbach · 2017-03-02T20:36:25Z

@fewi @MichMich Yeah, you can checkout the develop branch and build the image yourself by running:

docker build -t magic_mirror .

After building the image, run a container with this image by executing:

docker run  -d \
            --publish 80:8080 \
            --restart always \
            --volume ~/magic_mirror/config:/opt/magic_mirror/config \
            --volume ~/magic_mirror/modules:/opt/magic_mirror/modules \
            --name magic_mirror \
            magic_mirror

You might want to change the volume paths.

fewi · 2017-03-03T12:18:54Z

Yesterday I was trying to build & run it on my windows machine. But it did not work. I made a PR to fix this #743

AnyKey8472 · 2017-05-16T09:03:55Z

Hello everybody,
I tried to get this docker image to run on my 6.1.1 Synology DS, but strugled with the installation steps. After downloading it via synology gui and (what I first thought was the installation) unpacking it, I don't know how to run the above mentioned code.
I'm new to docker in generell and a little bit overwhelmed, is there a readme, or tutorial, how to setup your docker container on a synology system?
Thanks
Andre

Sebastian Limbach added 2 commits January 31, 2017 11:41

Added Docker support

354b745

Added Docker install documentation

a789737

roramirez reviewed Jan 31, 2017

View reviewed changes

roramirez suggested changes Jan 31, 2017

View reviewed changes

Sebastian Limbach added 2 commits January 31, 2017 19:40

Added the Docker support changes to changelog

e6a2b9f

Fixed typos and some description changes

a3eaf9f

bastilimbach commented Jan 31, 2017

View reviewed changes

bastilimbach and others added 2 commits January 31, 2017 19:48

Merge branch 'develop' into feature/docker

e68fea1

Fixed whitespace

42b806b

roramirez approved these changes Jan 31, 2017

View reviewed changes

MichMich merged commit 049d249 into MagicMirrorOrg:develop Jan 31, 2017

roramirez added a commit to roramirez/MagicMirror that referenced this pull request Feb 1, 2017

hotfix PL MagicMirrorOrg#673

2ea14e2

roramirez added a commit to roramirez/MagicMirror that referenced this pull request Feb 1, 2017

hotfix PL MagicMirrorOrg#673

ee0418e

MichMich added a commit that referenced this pull request Feb 1, 2017

Merge pull request #676 from roramirez/hotfix/MM_PORT

a9a90c5

hotfix PL #673

DNA2010 mentioned this pull request Apr 16, 2019

does not work AlexDespain01/mm-music-player#10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Docker support for server only mode #673

Added Docker support for server only mode #673

bastilimbach commented Jan 31, 2017 •

edited

Loading

roramirez Jan 31, 2017

bastilimbach Jan 31, 2017

roramirez Jan 31, 2017

bastilimbach Jan 31, 2017

roramirez Jan 31, 2017

roramirez Jan 31, 2017

roramirez left a comment

MichMich commented Jan 31, 2017

bastilimbach Jan 31, 2017

roramirez Jan 31, 2017

bastilimbach Jan 31, 2017

roramirez Jan 31, 2017

MichMich commented Jan 31, 2017

morozgrafix commented Feb 1, 2017

fewi commented Mar 2, 2017

bastilimbach commented Mar 2, 2017

MichMich commented Mar 2, 2017

bastilimbach commented Mar 2, 2017

fewi commented Mar 3, 2017

AnyKey8472 commented May 16, 2017

Added Docker support for server only mode #673

Added Docker support for server only mode #673

Conversation

bastilimbach commented Jan 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roramirez left a comment

Choose a reason for hiding this comment

MichMich commented Jan 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichMich commented Jan 31, 2017

morozgrafix commented Feb 1, 2017

fewi commented Mar 2, 2017

bastilimbach commented Mar 2, 2017

MichMich commented Mar 2, 2017

bastilimbach commented Mar 2, 2017

fewi commented Mar 3, 2017

AnyKey8472 commented May 16, 2017

bastilimbach commented Jan 31, 2017 •

edited

Loading