Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outsource Dockerfiles #856

Merged
merged 3 commits into from
Apr 19, 2017
Merged

Outsource Dockerfiles #856

merged 3 commits into from
Apr 19, 2017

Conversation

bastilimbach
Copy link
Contributor

@bastilimbach bastilimbach commented Apr 16, 2017

What does this PR do?

This PR deletes all Docker related files from this repository in favor of docker-MagicMirror.
Due to the issues described in PR #846 (comment) I decided to outsource the Docker Images so we can have multiple "versions" (Dockerfiles). The newly created repository creates the opportunity to have a Docker image with multiple base operation systems to choose from. You can now start Magic Mirror in server only mode on x86 systems by running:

docker run  -d \
			--publish 80:8080 \
			--restart always \
			--volume ~/magic_mirror/config:/opt/magic_mirror/config \
			--volume ~/magic_mirror/modules:/opt/magic_mirror/modules \
			--name magic_mirror \
			bastilimbach/docker-magicmirror

To start the server on a Raspberry Pi, use the raspberry tag:

docker run  -d \
			--publish 80:8080 \
			--restart always \
			--volume ~/magic_mirror/config:/opt/magic_mirror/config \
			--volume ~/magic_mirror/modules:/opt/magic_mirror/modules \
			--name magic_mirror \
			bastilimbach/docker-magicmirror:raspberry

I also included an alpine version:

docker run  -d \
			--publish 80:8080 \
			--restart always \
			--volume ~/magic_mirror/config:/opt/magic_mirror/config \
			--volume ~/magic_mirror/modules:/opt/magic_mirror/modules \
			--name magic_mirror \
			bastilimbach/docker-magicmirror:alpine

@z0diak could you test the latest tag on windows?
@MichMich If you're happy with my decision and don't want to deal with all the Docker Hub stuff, we can just leave bastilimbach/docker-magicmirror in the README and I will keep an eye on that. But I'm also happy to transfer the ownership of the docker-MagicMirror repository to you.

Related issues

#846 #835

TODO

  • Add changes to CHANGELOG

@bastilimbach
Copy link
Contributor Author

bastilimbach commented Apr 16, 2017

The raspberry image is currently failing on Docker Hub. I'm on it.

@MichMich
Copy link
Collaborator

Could you please include the changeling to this PR?

@MichMich MichMich closed this Apr 16, 2017
@MichMich MichMich reopened this Apr 16, 2017
@z0diak
Copy link
Contributor

z0diak commented Apr 17, 2017

@bastilimbach container downloads and runs ok. but application inside shows same symptoms like I described here: https://forum.magicmirror.builders/topic/2333/docker-setup-is-not-working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants