Allow using cocoapods without react native link #244
Conversation
|
|
|
@hccoelho Thanks for submitting a PR. Please give us a few days to review it and we will get back to you with our comments. |
guperrot
changed the title
|
Hi @guperrot, do you guys have thoughts on this? |
|
@hccoelho Thanks for waiting to hear back from us. We have reviewed the PR and it looks like a good feature add to App Center SDK. However, we are not looking to add this functionality in App Center at this point of time. My suggestion is to keep the PR open and we will get back to you once we decide to support it in App Center. Then we can work in collaboration to give you more direct feedback before merging in it our repo. Does that sound good? |
|
Thank you for the update. Unfortunately, this is a blocker for me as I explain here: #239. Any thoughts on how to get me unblocked? |
|
Hi @hccoelho, thanks for the PR. Looks like you're blocked by not able to install git sub-directory with yarn to consume your own branch. Have you tried |
|
Thanks @dhei. The solution requires me to keep appcenter code in my repo which is not ideal. I would like to migrate from HA but with this limitation is quite hard. Any ETA on when you guys can accept this PR or we can iterate over it? |
| s.source_files = "appcenter-analytics/ios/AppCenterReactNativeAnalytics/*.{h,m}" | ||
| s.author = { 'Microsoft' => 'appcentersdk@microsoft.com' } | ||
| s.source = { :git => "https://github.com/Microsoft/AppCenter-SDK-React-Native.git" } | ||
| s.source_files = "AppCenterReactNativeAnalytics/**/*.{h,m}" |
There was a problem hiding this comment.
Was that required that you replace some part of the paths with stars?
There was a problem hiding this comment.
Not required, however, this way it included sub-folders as well.
| s.source = { :git => "https://github.com/Microsoft/AppCenter-SDK-React-Native.git" } | ||
| s.source_files = "appcenter-crashes/ios/AppCenterReactNativeCrashes/*.{h,m}" | ||
| s.source = { :git => "https://github.com/Microsoft/AppCenter-SDK-React-Native.git" } | ||
| s.source_files = "AppCenterReactNativeCrashes/**/*.{h,m}" |
There was a problem hiding this comment.
I tested your branch on a sample project and this seems to work for cocopods project too. However before I merge, can you elaborate why it works to remove the beginning of the path, and what about the stars?
There was a problem hiding this comment.
Yep: the source_files path is related to the root of the .podspec file. So we want to include in the podspec all .h and .m files (including sub-folders thus **/*.{h.m}) in AppCenterReactNativeCrashes folder starting from the root.
Starting from 2 levels up in the filesystem path would break the spec since source files would not be found.
|
@hccoelho just 2 comments above in the thread to clarify but otherwise it looks good. Will wait for your replies before merging. |
This helps existing projects which consume dependencies via cocoa pods and not project references.
I did not change the behavior or react-native link since I'm ok if this is just for people who feel confident to integrate manually.
I'm really stuck on using appcenter since I can't yarn install from git subdirectories, otherwise, I would consume my private branch. Please advise. I'm more than happy to take on a different path.
here's the discussion: #239