-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react-native 0.53 prompt glitches when linking #252
Conversation
value: 'ASK_JAVASCRIPT' | ||
}] | ||
}]).catch((e) => { | ||
console.log(`Could not determine when to enable AppCenter crashes. Error Reason - ${e.message}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original log message Could not determine when to send AppCenter crashes.
sounds better to me, it's more accurate and informative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like we didn't have the same message as analytics then, I copied from there.
value: 'ASK_JAVASCRIPT' | ||
}] | ||
}]).catch((e) => { | ||
console.log(`Could not determine when to enable AppCenter crashes. Error Reason - ${e.message}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make sure eslint.sh linting passes for your PR. Other than that, PR looks good to me.
No description provided.