Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error catch logic in postlink scripts #256

Merged
merged 2 commits into from
Mar 2, 2018

Conversation

guperrot
Copy link
Member

@guperrot guperrot commented Mar 2, 2018

No description provided.

@guperrot guperrot requested a review from dhei March 2, 2018 00:24
@@ -8,7 +8,7 @@ if (rnpmlink.android.checkIfAndroidDirectoryExists()) {
.then(() => {
rnpmlink.android.removeAndroidDuplicateLinks();
}).catch((e) => {
console.log(`Could not configure AppCenter for Android. Error Reason - ${e.message}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not configure AppCenter Push for Android

Copy link
Member

@dhei dhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me except one minor wording

@dhei dhei merged commit 35956e8 into develop Mar 2, 2018
@dhei dhei deleted the fix/rn-link-error-management branch March 2, 2018 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants