Enhanced pod file integration #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhei
reviewed
Jul 30, 2018
| in ${this.file}, inside | ||
| the "target" section, then rerun the react-native link. AppCenter pods will be added below the comment. | ||
| `); | ||
| const projectDirectory = path.resolve(__dirname, '..', '..', '..', '..'); |
There was a problem hiding this comment.
Concat four '..' to find the project directory assumes "appcenter-link-scripts" npm module is located at "/node_modules/appcenter-link-scripts" rather than multiple level down under the "/node_modules" folder like "/node_modules/appcenter/appcenter-link-scripts". This shouldn't be a problem for anyone using npm v3 or later, so it's good. (I tested this pr works with npm v3.10.10, which is the version of npm on App Center Build VMs.)
dhei
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance current Pod file integration by adding dependencies to target with the current project name. If such a target is not found, a target is determined the old way. Addresses this issue #367.