Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement global.global #1658

Closed
bterlson opened this issue Sep 28, 2016 · 5 comments · Fixed by #5885 · May be fixed by softagram/ChakraCore#4
Closed

Implement global.global #1658

bterlson opened this issue Sep 28, 2016 · 5 comments · Fixed by #5885 · May be fixed by softagram/ChakraCore#4
Labels
Proposal
Milestone
Backlog

Comments

@bterlson
Copy link
Contributor

Global.global (eg. window.global in the browser, or this.global in ch.exe/etc) got stage 3 today. Let's get an implementation going!

Spec: https://github.com/tc39/proposal-global
@ljharb
Copy link
Collaborator

ljharb commented Nov 30, 2016

Ping! This would be great to get implemented ASAP.

@ljharb ljharb mentioned this issue Nov 30, 2016
Closed
31 tasks
@ljharb
Copy link
Collaborator

ljharb commented Apr 22, 2017

Please hold off on implementing this until a final location for the value is decided.

@MikeHolman MikeHolman added this to the Backlog milestone May 7, 2018
@ljharb
Copy link
Collaborator

ljharb commented Dec 19, 2018

This has now been renamed to globalThis. Will there be another version of Edge that includes ChakraCore? If so, it'd be great to ship this ASAP.

@rhuanjl
Copy link
Collaborator

rhuanjl commented Dec 19, 2018

I see no one is assigned to this - I could do it if wanted? (Will wait on a member of the CC team saying yes before I start though figure it will be very small, bulk of the work will be the tests)

@pleath
Copy link
Contributor

pleath commented Dec 19, 2018

That sounds great. No one is working on it on our side.

@rhuanjl rhuanjl mentioned this issue Dec 19, 2018
Merged
@TommiTallgren TommiTallgren mentioned this issue Jan 7, 2019
Open
chakrabot pushed a commit that referenced this issue Feb 1, 2019
@boingoing
[MERGE #5885 @rhuanjl] Implement stage 3 proposal globalThis
5d83d3e 
Merge pull request #5885 from rhuanjl:globalThis

This PR implements the stage 3 proposal globalThis.

1. Actual implementation is 2 lines of code
2. I've added a default enabled flag so it can be flagged off if ever necessary
3. I've added a few tests which I think should be sufficient
4. The large size of the diff is only due to it needing a byte code regen

cc: @ljharb @pleath

closes: #1658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
None yet
Milestone
Backlog
7 participants
@bterlson @ljharb @dilijev @MikeHolman @agarwal-sandeep @pleath @rhuanjl