Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

November, 2018 Servicing Update #5827

Merged
merged 10 commits into from
Nov 13, 2018

Conversation

pleath
Copy link
Contributor

@pleath pleath commented Nov 13, 2018

@akroshg
Copy link
Contributor

akroshg commented Nov 13, 2018

LGTM

Copy link
Contributor

@rajatd rajatd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pleath
Copy link
Contributor Author

pleath commented Nov 13, 2018

@dotnet-bot test

1 similar comment
@pleath
Copy link
Contributor Author

pleath commented Nov 13, 2018

@dotnet-bot test

@pleath
Copy link
Contributor Author

pleath commented Nov 13, 2018

@dotnet-bot test all

@mmitche
Copy link
Contributor

mmitche commented Nov 13, 2018

@pleath Close and reopen the PR. Jenkins has gotten confused and is updated status on an earlier commit instead of the head. It missed the synchronization update message most likely

@pleath pleath closed this Nov 13, 2018
@pleath pleath reopened this Nov 13, 2018
@chakrabot chakrabot merged commit 0b6dc52 into chakra-core:release/1.10 Nov 13, 2018
chakrabot pushed a commit that referenced this pull request Nov 13, 2018
chakrabot pushed a commit that referenced this pull request Nov 13, 2018
chakrabot pushed a commit that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants