Skip to content

Contributing Code

Patrick Nelson edited this page Sep 10, 2015 · 1 revision

Contributing Code to Concord Extensibility Samples

Before submitting a new sample or making extensive changes, please discuss it with the team. Submissions must meet a high bar for quality and design.

Sample Contribution Guidelines

  1. Follow the coding style. We use the .NET code style for C# files. The team enforces this by running the .NET code formatter tool on the code base. Contributors should ensure they follow these guidelines when making submissions.
  2. Entirely new samples or new features should be discussed with the team first or they will likely be declined.
  3. The goal of samples is to be simple and serve as a teaching tool. Contributions should not add new features or increase complexity unless there is a compelling reason to do so.
  4. All tests must continue to pass after a contribution including tests that are not yet open source.
  5. Only contributions against the master branch will be accepted. Authors submitting pull requests that target experimental feature branches or release branches will likely be asked target their pull request at the master branch.
  6. Pull requests that do not automatically merge with the tip of the master branch will be declined. The author will be asked to rebase to the tip and update the pull request
  7. Contributors must sign the Microsoft CLA
Clone this wiki locally