PowerStig.Convert needs to handle new registry rules without affecting existing code #160
Comments
chasewilson
pushed a commit
that referenced
this issue
Dec 20, 2018
* Updates for Office * Fix for Office Stigs * Removed debug line * Added new rules for Office * update for fixes * update for data clean up * update for office data clean up * update for core Data cleanup * update for code clean up * update for code clean up * updated data.office ValueName Twelve Match * Updates to fix registry rule integration tests * Added missing regex for office * Update for select in registrypath * Update Outlook 2013 Stig * Update for office registry value type * Updated RegEx for data.office * cleaned up data.office parsing rules * Updated data.office regex final * Updated test * Updates for unit test and new registry expression method * Updates from group review * Additional updates from team review * Added unit tests * Added expression file instructions and removed write-debug statements * Formatting updates * Fixed name change on variable * Update instructions and changelog * Update change log with link to github issue * Removed reference to release number * small fixes
athaynes
added a commit
that referenced
this issue
Mar 1, 2019
* Convert module update and processed files to support Kerberos policies (#219) * formatting * updated match * updated archive and parsed file * formatted files * added bullet list * rem space * added test data * updated V-2376-80 * formatting * fixed test data * Adding Exception, Skip Rules, and Skip Types to Integration Tests#201 (#221) * Upgraded integration tests * Updated Firewall Integration Test * Updated Windows DNS Server tests * Updated SQL Integration tests * Updated Office tests * Updated Oracle and Firefox Integration Tests * Updated Browser, Firefox, SQLServer integration tests * removed IISServer_Config mof * updated IIS schema and Integration Tests * Added multi skip rules to integration tests and fixed formatting * Updated changelog.md * Added exception testing to integration tests * updated changelog.md * updated formatting * updated spacing * Removed skiptype tests from configs that weren't required * Updated changelog.md for new standard * updated based on PR comments * updated CamelCase throughout * Refactor Registry RulesV2 resolves #160 (#193) * Updates for Office * Fix for Office Stigs * Removed debug line * Added new rules for Office * update for fixes * update for data clean up * update for office data clean up * update for core Data cleanup * update for code clean up * update for code clean up * updated data.office ValueName Twelve Match * Updates to fix registry rule integration tests * Added missing regex for office * Update for select in registrypath * Update Outlook 2013 Stig * Update for office registry value type * Updated RegEx for data.office * cleaned up data.office parsing rules * Updated data.office regex final * Updated test * Updates for unit test and new registry expression method * Updates from group review * Additional updates from team review * Added unit tests * Added expression file instructions and removed write-debug statements * Formatting updates * Fixed name change on variable * Update instructions and changelog * Update change log with link to github issue * Removed reference to release number * small fixes * updated based on PR comments, recreating branch due to merge issues * Further consolidation of integration tests, replaced % alias * Removed empty PowerSTIG folder * fixed rule hash table * updated IisSite Schema to include WindowsFeature DSC resource * Changed alias to * Updated oracleJRE.config * removed white space * shose#186SQLServer2016InstanceV1R3 (#235) * Updated to include more robust SQL parsing for SQL Server 2016 * Added SqlServer 2016 - New SecurityOption rules * Updates to improve SQL query parsing for SQL Server 2016. * Updated Get, Test, Set functions to leverage new SQL parsing routine. * More updates to Get, Test, Set scriptlets for 2016 * Added regex for sa account rule subtype * registry rule fix * fix formatting * Committing new SQL Server processed files. * Updated tests for SQL 2016, renamed Module Param * Convert module update and processed files to support Kerberos policies (#219) * formatting * updated match * updated archive and parsed file * formatted files * added bullet list * rem space * added test data * updated V-2376-80 * formatting * fixed test data * rename var * Updated to include more robust SQL parsing for SQL Server 2016 * Added SqlServer 2016 - New SecurityOption rules * Updates to improve SQL query parsing for SQL Server 2016. * Updated Get, Test, Set functions to leverage new SQL parsing routine. * More updates to Get, Test, Set scriptlets for 2016 * Added regex for sa account rule subtype * registry rule fix * Committing new SQL Server processed files. * Updated tests for SQL 2016, renamed Module Param * Updated changelog with new STIG * Updated SQL Script Query Rule Audit functions * Updated SQL Server 2016 Audit Get/Test functions * Upated SqlScriptQueryRule Match * Updated SQLScriptQueryRule Audit functions * Completed SQLScriptQueryRule Audit SetScript * Updated match statements * Updated Split-BenchmarkId to recognize new SQL Server 2016 format * Updated SqlServer-2012-Instance-1.17 based upon new code processing * Update SecurityOption rule conversion w/o Xccdf modifcations * Update range conversion match for SQL 2016 SecurityOption rule types * Updated SecurityOption Tests and related data to build the test cases * Added tests for SqlScriptQueryRule saAccount and updated some bugs * Updated SQL Server 2016 Instance output * Added tests for SqlScriptQueryRule Audit and updated some bugs * Finalized tests for SQLScriptQueryRules for SQLServer 2016 Instance STIG * Updated SQL Server 2016 Instance V1R3 STIG data files. * Updated scripts to fix AppVeyor issues * Updated Convert.main.integration.tests.ps1 to show correct test counts by type. * Remove file not needed * Updated STIG file name in test hash table to correct name. * Updated code for erring permissions rule. * Removed tabs from source xccdf which cleared them from processed file * Manually added a newline to the org output file. * Minor updates based on PR feedback * Formatting updates per PR review * Updated SQL Server Instance STIG processed output files * Added missing STIG version * Revised get, test, and set scripts from multi- to single line format. * Minor formatting updates * Minor formatting update * Minor update to moduleversion * Minor updates to formatting, changelog * Updated a unit test to reflect code change * Minor updates - case, plural/singulars, etc. * Updated SAaccount to SysAdminAccount for case * Updated test file with revised SysAdminAccount name * Updated unit test syntax to correct saAccountName * Removed DbExist SqlScriptQuery rule sub-type and updated unit test * Removed DbExist SqlScriptQuery rule subtype parsing * updated config format and helper.psm1 * Add Windows Defender Antivirus STIG V1R4 (#239) * add xccdf * add defender info * for no longer optional * catch through as org * valuename cleanup * should not catch as org * defender specific * fix formatting * typo fix * adding for org setting * add for v-75153 * add defender exceptions * defender exceptions * unneeded comment * add powerstig xmls * add defender test * add newline * roll back due to failing test * pass valuename * update comment * add regex for absent * regex cleanup * update for small fix * Adding Windows Server 2016 STIGs (#206) * Updated Validation Set * updated cAdministrativeTemplateSettings * Spacing fix * Added archived DotNet 1.6 STIG * Added process DotNet 1.6 STIGs * Updated DotNet Framework changelog and rename of processed STIG in integ * initial commit * fix rule 76827 * add files and update tests * added blank line to changelog * Updated to catch Absent ValueType * Updated regex valuename * removed tabs\spacing * fix formatting * fix formatting * fix formatting * initial commit * update integration test * updated xml files * update to catch client and server * fix formatting * update test to account for new scenario * fix formatting * fix formatting * Added AD Domain STIG V2R11 and removed V2R8 * Updated for DotNet v1r4 registryrule to convert to documentrule. * Updated matching Stig file names and rule types * Added newlines at the end of the files * Updated changelog bulleted list * Updated changelog.md V2R11 * Readded Forest STIG to integration test * test * Revert acc85d5 * revert * revert 0659913 * revert 8fed9fc * revert 47c3aa7 * git revert 4fe8501 * Updated Archive stig name in int.test * fix formatting * new processed xml * delete xmls * initial commit * initial commit * fix rule 76827 * add files and update tests * fix formatting * new processed xml * delete xmls * update test to account for new scenario * fix formatting * initial commit * update integration test * updated xml files * update to catch client and server * fix formatting * update test to account for new scenario * fix formatting * fix formatting * initial commit * update integration test * fix formatting * fix formatting * fix formatting * fix formatting * fix formatting * Kickoff build * Kickoff build * fix formatting * commit * removed space * Updated CHANGELOG.MD * updated processed stig to match 2.3.0.0 * post merge conflict cleanup * removing whitespace * test * test2 * Updated registryrule for rule v-81495 * updated * test * test * Updated ValidateSet for 1.6 * Removed erroneous STIG in changelog * Rename StigDdata to STIG (#178) * initial commit * renamed GetAvailableStigs * Update README.md * Updated based on PR feedback * Updated based on PR comments * Updated registry rule match to single line * Removed #Test * Commits based on PR * fix rule v-76845 * fix formatting * add windows domain * add windows domain * fix conficts * Updated OrgValueTestString based on PR * fix formatting * Update to fix rule splitting issue * update to fix tests * updated * updated based on PR * updated based on PR * fix conficts * iis site updates * new stigdata update integration tests * update tests * new data file * readd tests * update tests * updated resource name * updated hkcu resource * fixed paths * update resource name * fixed path * fixed path * updated change log * added files to archive * rem old files * added stig to archive * fixed name conversion * rem V-21954 hard coding * fixed ctrl pnl path * rem SupportedEncryptionTypes filter * ordered svc list * Fixed V-1089 * fixed path * fixed legal text * added content * added future note * updated range conversion pattern * added RuleIdFilter * Lansey174 firefox stig (#198) * Adding converted Firefox 4.23 udate .xml files * Updated Version in validate set * Added Firefox stig to archive * Updated Firefox stig in archive * Updated rule count * Added test data file for Firefox Regex * Updating validate set and regex for Firefox 4.23 parsing. * Updated valiation set for both version of FireFox * Udpated ChangLog and Convert.Main.Integration.tests.ps1 * Added new line at end of XML file * Updated converted Firefox 4.23 STIG * Updated FireFox Conversion files * Updated FileContentRule.test * Updated FileContentRule.psm1 * Updated revised FireFox 4.23 stig * Added space to end of line * Updated Rule count * Removed added file * Updated line 127 * Added line 165 back * Updated Changelog.md * Updated Change log * fix merge conflicts * Fixed Copy Rule * added MS Files * added 2.14 DC files * fixed parse errors * updated expected output * added xRegistry * added cAdministrativeTemplate * updated param set * fixed path * updated resources * fixed path * rem tab * rem old files * Fixed V-21954 * update expected result * Updated rules * rem unused test * updated stigdata * added newline * update param set * manual update V-26070 * updated fix list * rem unsupported files * fixed name * split file * initial files * Fixed USR ident * fixed v-73685 * fixed V-73645 * fixed guest group * fixed ace paths * default org settings * fixed usr identity * to do list * fixed caption rules * fixed 73239 * fixed tests * Fixed service name extraction * rem dup tests * fixed metadata * added MS settings * added 2016 * fixed telnet rule * added 1.6 to param set * added new line * fixed telnet name * added 2016 * added DSA filter * added Kerberos policy * added 2016 to validateset * filter md files * fixed 73277 * updated V-73711 * fixed 73711 * fixed 73551 * added notes * formatting * fixed 73649 * rem hex code from test string * formatted rule check-content * updated Windows Feature regex * formatted rules * added ShouldBeAbsent * update with latest convert applied * fixed tests * fixed default value * added quotes to test strings * updated test data * added notes * fixed duplicate entries * fixed Inheritance * fixed V-73759 * updated V-73759 * updated test data * updated rights * fixed rule inheritance * added description field * Added description filter * added PR feedback * changed rawString export to default * fixed value (#248) * renamed AccountPolicyRule * fixed spelling * updated class name * updated convert factory * fixed path * renamed class * renamed class * Added AsRule * renamed module * updated Rule base class * temp rem dsc integration tests * initial commit * Add Windows Server 2016 V1R7 (#253) * fixed space * added ms stig * fixed Identity * Add DC stig * added xccdf * updated change log * updated checklist data * fixed test errors * updated composite resources * fixed common tests * fixed xRegistry test * fixed more tests * fixed tests * rem validateset * updated paths * updated tests * Added null version support * updated type * moved data files * aligned parameters * fixed rule tests * added STIG unit test * fixed STIG tests * fixed base class call * fixed common tests * updated composite manifest and help * updated properties * fixed property name * fixed stigdata lookup * fixed path * updated test config data * Updated module manifest to reflect new AccessControlDsc 1.2.0.0 release (#254) * updated module manifest to reflect new AccessControlDSC release 1.2.0.0 * updated composites to reflect the correct version of AccessControlDSC * fixed IE and Server tests * updated mock * removed test * updated comments * revert updates * fixed name * add log automation * updated log files * added new line * fixed output name * updated nuspec to reflect new project structure * Fixed Get-StigList technology filter * updated release module * Update after STIG application and validation * Update renaming IIS Site Stig * updated merge type * rem deleted function export * fixed variable * update for Registry unit tests. Tests need rewrites. * update for test * revert back to passing tests. * added PR feedback * Fixes #284 (#288) * Updated to remove edge case and added xccdf.log * updated to correct white space in key and removed edge case associated with space * updated changelod.md * updated based on PR * updated whitespace * update 1.14 org setting * new line added to org * update for edgecase removal * update to remove edgecase text * Update to remove bad tests * Duplicate and/or ExclusionRuleList Conversion Error -> Fixes #289 (#291) * Updated DocumentRule and DocumentRuleConvert Classes to parse correctly. * updated changelog.md * rem old STIG files * Update to README for file hash updated hyperlink * Update to Merge 3.0.0.0 * Update Org Settings * Update for new lines. * Update after single quotes added * Update after adding single quotes on line 22 * Fixes #294. Data updates test fix (#295) * update for bug in access control with log * update for fix * update for fix * update for fixed data * update for fix * Update to conform to new conversion process * added help content * Audit policy convert rule refactor (#286) * rem deleted function tests * refactor convert class * update for bug in access control with log * update for fix * update for fix * update for fixed data * update for fix * updated Syntax * Fixes #243 (#287) * move archive files * added log text update * added change log * rem old STIG files * apllied updated to 1.16 * rm 1.12 from archive * formatting * Deleted empty directory * new common tests (#300) * Common convert tests (#301) * new common tests * added missing test data warning * Clean up STIG data (#297) * renamed files * rem out of scope files * rem old files * Refactors the Account Policy Convert module (#296) * added change log * refactor class * Fixed extraction regex * refactored and rem dup tests * additional refactor * fixed formatting * fixed test data * cleaned up test data * updated to new test format * updated path * changed scope * added global * IIS Server STIG V-76731 fails to properly set STIG guidance because rule is not split -> Fixes #290 (#292) * Fixed parsing bug for V-76731 * Converted STIGs to include previous split parsing updates. Also added to changelog * Fixed errors included no new lines, extra white space and removing old processed stigs. * Fixed issue with org settings and converted IIS Server 1.6. * Fixed whitespace in org setting. * Added punctuation * Added section in integration test for this split rule. * U_IIS_8-5_Server_STIG_V1R3_Manual-xccdf.log added * Refactors the Security Option Convert module (#299) * added update log * updated regex * refactor module * cleaned up test data * Added new test format * added global * updated path * Introduce a split rule factory (#303) * Added Split Factory * fixed rule ctor * updated notes * Audit policy common test (#304) * added common tests * updated method name * rem gt N-2 (#310) * Update PowerSTIG to Utilize LogTargetW3C parameter in xWebAdministration 2.5.0.0 * update changelog * test * New-StigChecklist path validation (#307) * rem unused files * added path validation * added notes * added initial test * fixed path * Migrate to xWindowsFeature (#306) * migrated to xWindowsFeature * migrated to xWindowsOptionalFeature * updated notes * updated changelog * fixed spelling * Fixed resource import * test2 * removed whitespace from test2 * updated to parse the STIG properly * Adds common unit tests (#313) * fixed spelling * rem extra return * moved to common tests * added tests * added remaining tests * rem spaces * update registry rule path * updated exclude list * added PR feedback * Update to rename Firefox STIG * updated composite for unique values * Update after conversion * Update * Update to remove issue in Firewall XML * need to have a function that will get unique ssl flags * Corrected formatting issues * removed helper function * updated xWebConfigProperty * updated xWebConfigPropertyv2 * reverted changes in xWebConfigProperty * updated PowerSTIG to add xSslSetting resource * added iis site 1.5 STIG * updated spacing * updated rule.loadFactory * updated powerstig.convert.psm1 * bug fix for issue 331, checkcontent notmatch string fix * updated xccdf.log files * removed old stigs * Update after correcting 1.7.org.default OrganizationalSetting * Updated ChangeLog * Update after adding new lines * Update - removed CHANGELOG.md, line 31 at r3 * updated Rule convert * Update after reconversion * Security option fix (#328) * return single match * cleaned up match pattern * Update: Removed spaces * Update to uses AccessControlDsc * Update to add to changelog and minor adjustment * updated SSlSettingsRules * updated changelog * updated Integration tests and unit tests * Update: Module directory formatting * Updated composite * Commit to fix failing unit test * update to remove unneccessary section * update to remove extra line * update to undo caps * update to fix typo * Update to fix PR Comments * updates for PR comments * update for PR comments' * update for extra spaces * Update to see if tests will Pass * updated version number (#338) * update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Newly added registry rules can and do break existing rules
Describe the solution you'd like
Registry rules should be broken into different files, so newly needed rules can't affect existing rules
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: