-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "Compiler Plugins" #16607
Comments
@rbuckton and I have some offhand thoughts about this
In general this isn't simple but we're open to at least hearing ideas. |
I'm not familiar with TypeScript well enough to write a proposal. Instead I can list a few plugins that can be useful and exist in the wild in other forms (Webpack plugin, Babel transforms) to make a case for having such extensibility: Custom module resolution
Code transformers
Emitting other code
Providing types
There are so many other use-cases for compiler plugins that I'm not aware of but I'm sure compiler plugins will make TypeScript ecosystem thrive. |
i think that this can be a very powerful feature. |
Big yes to this feature being supported by TypeScript. I propose that the plugin system should be implemented using streaming pattern. // NodeJS stuffs
import * as stream from 'stream';
import * as path from 'path';
export enum TypeScriptModuleEnum {
CommonJS, AMD, System, UMD, ES6
}
export interface ITypeScriptTransform {
(filename: string, module: TypeScriptModuleEnum): stream.Transform
}
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// As sample plugin to transform file content into string if matches extensions. Handy for templates.
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Plugin creators can use this to extend TypeScript!
import * as through2 from 'through2';
export interface IStringifyOptions {
extensions: string[]
}
function doStringify(filename: string, extensions: string[]) {
return extensions.includes(path.extname(filename));
}
export function StringTransform(options: IStringifyOptions): ITypeScriptTransform {
return function (filename, module) {
return through2(function (file, encoding, next) {
// Determines whether we should stringify the file.
// For example, the file name = 'test.txt' and extensions list = ['.txt', '.html']
if (!doStringify(filename, options.extensions)) {
return next(null, file);
}
let s = JSON.stringify(file);
if (module === TypeScriptModuleEnum.CommonJS) {
s = 'module.exports = ' + s + ';\n';
return next(null, s);
} else {
return next({
message: 'Module not supported!'
});
}
});
};
}
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Later...
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
import * as ts from 'typescript';
import { StringTransform } from 'StringTransform';
let tsString = StringTransform({
extensions: ['.html', '.txt']
});
ts.useTransforms([tsString]);
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Later in application source code...
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
import s = require('./test.txt'); This system has the following benefits:
|
Something similar to browserify transforms or webpack loaders would be very powerful and cover most of these use cases. |
looking forward to see this feature implemented! 🙌 |
Currently |
Transformers do not allow custom module resolution or extra file emit |
@mohsen1 Yes, you're right. I was suggesting it as an approach for your first point "Apply transformers". For a plugin to do all the things suggested in your issue description is too broad of a scope, as @DanielRosenwasser noted. I think exposing custom transformers is the highest value feature of the suggested and it's also the most simple to implement taking into account the way the TS compiler currently works. |
@Jack-Works Isn't Language Service doing it already? |
Any news on this? I'm writing a plugin, and would like to just plug it on my current setup (tsc & webpack + awesome-typescript-loader). |
Regarding this topic I have some tips. It would be great if loading of plugins is configurable through the tsconfig.json file. Thats because i.e. VS code syntax highlighter / lens / intellisense will use the same plugins as the compiler during the regular build. Plugin can be standard Node module and can be resolved in the standard CommonJS way. When the plugin for the typescript compiler will be defined in the tsconfig.json file it should be loaded during the tsc startup and tsc should provide access to all currently available tsc APIs (it would be also great if extended tsconfig can be read through API too as when I was playing around the API about year ago i had to write custom config reader / extender, what is not good as with next release of ts you can remove or add some options and its hard to maintain the code afterwards ;). During the init phase, the plugin can replace various stages of the compiler API with custom implementations (such as file reader) or bind event listeners to events occurring during the compilation process (file load, resolve, parse, transform, emit...). Events with "pre" and "post" would be also great in order to pre-process or post-process the stage data while original components are still in use. I.e. preParse is great time to run text preprocessor which can implement #ifdefs and replace them with empty lines to keep it possible to generate source maps properly, or postParse when AST can be searched for dead code and the dead code can be removed from furthermore processing.
If this would be possible we can simply use various plugins for code preprocessing, death code elimination, output minification or whatever else we can imagine directly under the hood of the compiler "executable" but without touching the compiler code itself. Currently, we have to write everything as a new compiler using the tsc API. Unfortunately, this later means we have to implement the "new" compiler to our development tools (such as VS code or full VS, what is almost impossible ;). |
I would really need this one. The ideal spot for synthetic code injection is after the parsing phase: here you have the AST ready, you can do some enhancements, and they are already available to language service! |
I think it is enough if you can replace the parser with custom one and inside of it you would do your pre, call original parser with modified input and your post where you would modify the AST. |
Please make it happen. |
Now that Babel 7 has the support for TypeScript, would it be possible to achieve that trough Babel? |
@xtuc i think this would break all existing tooling etc. Personally i belive that type providers should be a way to extend typescript (only type system). |
I've been working on this plugin, and I would love that it would work during build - and not just when working with files in the IDE. |
I really love TypeScript but I think that this is a feature that is really missing. I have a few thoughts about it: Naming - How would the naming structure be like?How would we publish plugins for others to use them? Of course everyone could use its own name but I think that is not good. Then we will see names like
We would have to choose one of them or just let people choose one for their plugin, but that doesn't seem to be so great to me. Another thing also included below is local plugins (no npm modules). I don't think we should add a naming convention to them, because people have to choose themselves what they do in their projects. Loading - How do we tell the compiler to load a specific plugin?There is currently a {
"compilerOptions": {
// some other options...
// array of plugins
"compilerPlugins": [
// version 1 - string including the path or module name
"@typescript/plugin-cool-features", // npm modules
"./typescript-cool-plugin.ts", // for local ones
// version 2 - configuration with an object
{
"name": "@typescript/plugin-cool-features-with-options",
"options": { // add type checking for this
"coolOption": "cool value"
}
}
]
}
} Implementing - How do we write the actual plugin implementation?Plugins should always be written in TypeScript. All functionallity should be exported in one single file, the file registered in import { Plugin, FileType } from "typescript/plugins";
// notice this, there should be a base class and some helpers in "typescript/plugins"
// enough to allow resolves of ".svelte" files like `import App from "./App"` with file "App.svelte"
class SvelteFileType extends FileType {
name = ".svelte";
}
interface Config {}
export default class CoolPlugin extends Plugin {
static info = {
// don't know if this is needed
}
init(config: Config) { // can request config
this.context // current context (can add things like providers and listeners and is used to remove all added things when disabling this plugin)
this.context.parser.on("preparse", () => {});
// i don't know what things should be possible here
this.context.registerImportResolver(data => {
return "resolvedFile.ts";
});
this.context.registerFileType(SvelteFileType);
}
remove() {
// optional, if you have any sub-objects to destroy do this, all listeners are removed automatically
}
} Example - Implicit
|
@DanielRosenwasser following up on this:
Would it be helpful to open an issue focusing specifically on just running the LS plugins that can already be configured in tsconfig? Is that something that's actionable before designing a more full-featured compiler plugin API? We have a lot of customers who would benefit from more build-time checking, not just editing-time checking, and they're sometimes and understandably wary to replace Also, it does seem confusing to me that the |
Transformers would be a huge fin in simplifying our toolchains. |
This would be huge for a project I'm working on where the goal would be to generate an application based on typings. The issue that I can't really work with interfaces at runtime would be solved if I could inject code in the compile step. |
(copied from #39784 (comment)) |
It would be great if TypeScript natively supported pre-processing plugins / transformers so that someone in the community (or TypeScript) could create a system like Flotate, and solve the problem of JSDoc being hard to work with to define types (and still avoid compilation). |
Funnily enough, even though I left the last comment, I had another use case for this pop up this week, which was I think I should be able to use a project like typescript-rtti (provides runtime type reflection) without requiring a fork of TypeScript. |
Not sure to understand well but is this topic related to the fact that TypeScript plugins (like typescript-strict-plugin) don't work at compile-time ? |
With This is a perfect example of where plugins could add a lot of value outside of the IDE. |
I might be wrong here, but I think that with |
Would that be during compile/build, or only in the IDE @jakebailey? |
Just IDE, as there are no compiler plugins (that's this thread). e.g. getScriptSnapshot or via the FS. |
Do you think the TypeScript team would be more open to compile-time plugins if they were limited to providing type information, perhaps only running with This would solve some high value use cases, like importing classes from CSS modules, nodes/queries from GraphQL, etc. |
Piling on, I would love tsc to provide compiler plugin support. Similar to others in this thread, in order for me to compile my TypeScript React library, I have to use Rollup + a number of CSS plug-ins to process my CSS module imports. The only "tsc-only" solution is to use a CSS in JS library like emotion. However, that comes with its own trade offs. |
Since the proposal from this issue has not yet been implemented since 2017, it may require too much change from the TypeScript team. How do you like the most simplified version: feat(tsc): allow the |
@KostyaTretyak I think, at this point, Although I feel like TypeScript should allow this, I agree it might just never happen. |
From wiki:
TypeScript plugins are very limited. Plugins should be able to:
LanguageServiceHost#resolveModuleNames
)The text was updated successfully, but these errors were encountered: