Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSX spread children #9495

Closed
calebmer opened this issue Jul 2, 2016 · 2 comments
Closed

Add JSX spread children #9495

calebmer opened this issue Jul 2, 2016 · 2 comments
Assignees
@sandersn
Labels
Committed The team has roadmapped this issue Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Milestone
TypeScript 2.2

Comments

@calebmer
Copy link

calebmer commented Jul 2, 2016

The JSX specification was just updated (here: facebook/jsx#59) to add for JSX spread children. See the rationale here: facebook/jsx#57

What would be involved in adding support for this new feature of the JSX specification to the TypeScript parser?
@mhegazy
Copy link
Contributor

mhegazy commented Jul 4, 2016

the change should not be that big to the parser, there are changes needs to the checker, and the emitter as well.
PRs are welcomed

@mhegazy mhegazy added the Suggestion An idea for TypeScript label Jul 4, 2016
@mhegazy mhegazy added this to the TypeScript 2.1 milestone Jul 4, 2016
@mhegazy mhegazy assigned sandersn and unassigned RyanCavanaugh Jul 4, 2016
@sandersn sandersn mentioned this issue Oct 13, 2016
Merged
@sandersn
Copy link
Member

#11591 adds this feature.

@RyanCavanaugh RyanCavanaugh added the Committed The team has roadmapped this issue label Oct 13, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.1, TypeScript 2.1.2, Future Oct 27, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.2, Future Dec 22, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Dec 22, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandersn sandersn

Labels
Committed The team has roadmapped this issue Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 2.2
Development

No branches or pull requests
4 participants
@sandersn @RyanCavanaugh @mhegazy @calebmer