Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At <div x=/**/, completion insertText should be wrapped in braces #21372

Merged
2 commits merged into from
Jan 25, 2018
Merged

At <div x=/**/, completion insertText should be wrapped in braces #21372

2 commits merged into from
Jan 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2018

Fixes #21341

Includes a fix from #21330 but I would prefer #21342, so must wait on that to merge before merging this.

@ghost ghost requested a review from armanio123 January 23, 2018 21:45
@DanielRosenwasser
Copy link
Member

How does this work with string literal completions in these locations?

@ghost
Copy link
Author

ghost commented Jan 23, 2018 •
edited by ghost
Loading

getStringLiteralCompletionEntries goes through a different code path since it doesn't use symbols, so it won't be affected by this. (Also, you have to write "" to get the string literal completions -- maybe we should reconsider that now that we have insertText?) I'd write a test for that, but due to #21374 we will crash when trying to get details for the completion.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 24, 2018

@andy-ms can you also port this to release-2.7 as well.

@ghost
Copy link
Author

ghost commented Jan 24, 2018 •
edited by ghost
Loading

Waiting on #21342 (or #21330)

@ghost ghost force-pushed the completionsJsxAttributeInitializer branch from caf23d6 to 9f25d82 Compare January 25, 2018 16:20
@ghost ghost force-pushed the completionsJsxAttributeInitializer branch from 9f25d82 to 0488325 Compare January 25, 2018 16:20
@ghost ghost mentioned this pull request Jan 25, 2018
Closed
@ghost ghost merged commit dcd3b5e into master Jan 25, 2018
@ghost ghost deleted the completionsJsxAttributeInitializer branch January 25, 2018 17:02
ghost pushed a commit that referenced this pull request Jan 25, 2018
At <div x=/**/, completion insertText should be wrapped in braces (#…
8cac17b 
…21372)
@ghost ghost mentioned this pull request Jan 25, 2018
Merged
ghost pushed a commit that referenced this pull request Jan 25, 2018
At <div x=/**/, completion insertText should be wrapped in braces (#…
a453149 
…21372) (#21409)
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armanio123 armanio123 Awaiting requested review from armanio123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't provide completions after = in JSX
2 participants
@DanielRosenwasser @mhegazy