Resolve aliases before using getTypeReferenceType #24594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
force-pushed
the
fix-aliased-import-type-lookup
branch
from
a9948b6
to
01a4928
Compare
|
man.. that is subtle.. |
mhegazy
approved these changes
Jun 4, 2018
|
@mhegazy should this be ported to 2.9 since it fixes a bug in generic import type resolution? |
|
yes please. |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Jun 4, 2018
weswigham
added a commit
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at this comment, I couldn't repro the reported issue (a visibility error); but I could witness another problem with the generated file:
As it happens,
getTypeReferenceTypesilently returnsundefinedonAliases (resolveEntityName never returns an alias and is the only other place symbols come from when they are passed into it). So externally aliased types (aka those looked up via export specifiers) couldn't be found.